NAK: [SRU][G][PATCH 1/1] net/mlx5e: Add missing capability check for uplink follow

[Frank Heimes]

Ok, I'll send a v2 like this ...

Thx, Frank

On Fri, Mar 26, 2021 at 5:47 PM Krzysztof Kozlowski <
krzysztof.kozlowski at canonical.com> wrote:

>
> On 26/03/2021 17:42, Frank Heimes wrote:
> > Hi Krzystof, well, it was done that way by me by intention. Yes, Aya
> > Levin is the upstream original author of the commit (as it is in
> > 5.11). But Alexander is the author of the backport(s).
> >
> > That is how I always submitted such patches/backports in the past.
> >
> > So what is expected then? Just to double check:
> >
> > Replace: "From: Alexander Schmidt <alexschm at de.ibm.com
> > <mailto:alexschm at de.ibm.com>>" by : "From: Aya Levin <ayal at nvidia.com
> > <mailto:ayal at nvidia.com>>" (even if the backport was done by
> > Alexander ?)
>
> Yes, the From: is the author of the original patch.
>
> >
> > And then adding: "Signed-off-by: Alexander Schmidt
> > <alexschm at de.ibm.com <mailto:alexschm at de.ibm.com>>" (on top of:
> > "Signed-off-by: Aya Levin <ayal at nvidia.com <mailto:ayal at nvidia.com>>
> > and "Signed-off-by: Frank Heimes <f
> > <mailto:ayal at nvidia.com>rank.heimes at canonical.com
> > <mailto:rank.heimes at canonical.com>>   )
>
> The Signed-off-by are added incrementally in a chronological order, so
> (beginning coming from original commit):
>
> Fixes: 7d0314b11cdd ("net/mlx5e: Modify uplink state on interface up/down")
> Signed-off-by: Aya Levin <ayal at nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe at nvidia.com>
> Signed-off-by: Saeed Mahameed <saeedm at nvidia.com>
> Reported-and-Tested-by: Alexander Schmidt <alexschm at de.ibm.com>
> (backported from commit 9c9be85f6b59d80efe4705109c0396df18d4e11d)
> Signed-off-by: Alexander Schmidt <alexschm at de.ibm.com>
> Signed-off-by: Frank Heimes ...
>
> Thanks!
>
> Best regards,
> Krzysztof
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210326/2cb69d8c/attachment.html>