[SRU][G][PATCH 1/1] net/mlx5e: Add missing capability check for uplink follow

[Frank Heimes]

Hi Krzystof,
well, it was done that way by me by intention.
Yes, Aya Levin is the upstream original author of the commit (as it is in
5.11).
But Alexander is the author of the backport(s).

That is how I always submitted such patches/backports in the past.

So what is expected then? Just to double check:

Replace:
"From: Alexander Schmidt <alexschm at de.ibm.com>"
by :
"From: Aya Levin <ayal at nvidia.com>"
(even if the backport was done by Alexander ?)

And then adding:
"Signed-off-by: Alexander Schmidt <alexschm at de.ibm.com>"
(on top of:
"Signed-off-by: Aya Levin <ayal at nvidia.com>
and
"Signed-off-by: Frank Heimes <f <ayal at nvidia.com>rank.heimes at canonical.com>
 )

Do you expect it like this?

Bye, Frank

irc: jfh -- ubuntu-on-big-iron.blogspot.com
<http://ubuntu-on-big-iron.blogspot.com/?view=sidebar>


On Fri, Mar 26, 2021 at 5:29 PM Krzysztof Kozlowski <
krzysztof.kozlowski at canonical.com> wrote:

> On 26/03/2021 17:27, Krzysztof Kozlowski wrote:
> > On 26/03/2021 17:21, frank.heimes at canonical.com wrote:
> >> From: Alexander Schmidt <alexschm at de.ibm.com>
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/1921104
> >>
> >> Expose firmware indication that it supports setting eswitch uplink state
> >> to follow (follow the physical link). Condition setting the eswitch
> >> uplink admin-state with this capability bit. Older FW may not support
> >> the uplink state setting.
> >>
> >> Fixes: 7d0314b11cdd ("net/mlx5e: Modify uplink state on interface
> up/down")
> >> Signed-off-by: Aya Levin <ayal at nvidia.com>
> >> Reviewed-by: Moshe Shemesh <moshe at nvidia.com>
> >> Signed-off-by: Saeed Mahameed <saeedm at nvidia.com>
> >> Reported-and-Tested-by: Alexander Schmidt <alexschm at de.ibm.com>
> >
> > Alexander's signed-off-by is missing here. Since his the author (From),
> > his SoB is expected to be the first.
>
> I see in original commit Aya Levin as the author, so the From field got
> corrupted during format-patch.
>
>
> Best regards,
> Krzysztof
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210326/343159f6/attachment.html>