NAK for [F/G]: [PATCH 0/1][SRU][F][G][H][OEM-5.10] Dell Precision 5550 takes up to 10 seconds to respond when coming out of sleep

[Tim Gardner]

On 3/23/21 2:36 AM, Stefan Bader wrote:
> On 19.03.21 19:56, Tim Gardner wrote:
>> Applied to focal/groovy linux-master-next. Thanks.
>>
>> I assumed Timo and Andrea would have dropped an Acked-by if they had 
>> more time in their busy schedules, so I used their Acked-by signature 
>> names in vain when applying this patch to Focal and Groovy.
>>
>> -rtg
>>
>> On 3/15/21 2:05 AM, AceLan Kao wrote:
>>> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1919123
>>>
>>> [Impact]
>>> On some platforms, the EC doesn't support the register reading sequence
>>> for sentelic[1], and then make the EC can't respond commands for a while
>>> when probing. It leads to the keyboard is non-responsive for around 10
>>> seconds while waking up from s2idle.
>>>
>>> [ 44.304488] i8042: [9804] d4 -> i8042 (command)
>>> [ 44.304634] i8042: [9804] f3 -> i8042 (parameter)
>>> [ 44.304787] i8042: [9804] fa <- i8042 (interrupt, 1, 12)
>>> [ 44.304855] i8042: [9804] d4 -> i8042 (command)
>>> [ 44.304938] i8042: [9804] 66 -> i8042 (parameter)
>>> [ 44.337698] i8042: [9813] d4 -> i8042 (command)
>>> [ 44.905695] i8042: [9942] 88 -> i8042 (parameter)
>>> [ 45.497478] i8042: [10102] d4 -> i8042 (command)
>>> [ 46.098041] i8042: [10253] f3 -> i8042 (parameter)
>>> [ 46.098070] i8042: [10253] fe <- i8042 (interrupt, 1, 12)
>>> [ 46.718154] i8042: [10386] d4 -> i8042 (command)
>>> [ 47.309915] i8042: [10386] f4 -> i8042 (parameter)
>>> [ 47.918961] i8042: [10556] d4 -> i8042 (command)
>>> [ 48.402624] i8042: [10556] f6 -> i8042 (parameter)
>>>
>>> [Fix]
>>> A DMI quirk to mark this platform doesn't have aux device could avoid
>>> those commands to be sent. And the system could still using i2c
>>> interface to communicate with the touchpad.
>>> https://lkml.org/lkml/2021/3/15/126
>>>
>>> [Test]
>>> Verified on Dell Precision 5550
>>>
>>> [Where problem could occur]
>>> The quirk only affects the listed platform, there is no regression 
>>> could occur.
>>>
>>> Chia-Lin Kao (AceLan) (1):
>>>    UBUNTU: SAUCE: Input: i8042 - add dmi quirk
>>>
>>>   drivers/input/serio/i8042.c | 21 +++++++++++++++++++++
>>>   1 file changed, 21 insertions(+)
>>>
>>
> I don't think this patch should have applied as it has no ACKs at all. 
> Also this is a patch which had, when submitted, not even reached 
> linux-next upstream which imo should be a requirement for stable release 
> updates.
> Please drop it again from G and F, if it has reached linux-next we can 
> properly ack it and then apply it non-SAUCE and with proper upstream 
> SHA1 reference.
> 
> -Stefan
> 

As you wish, though we have applied SAUCE quirk patches of this nature 
in the past. It can only affect Dell Precision 5550 platforms. I 
considered it quite low risk.

As for the oem kernels dudes, if you're applying a patch that is for 
more then just your oem kernel, then take the time to evaluate it for 
applicability to the other series mentioned in the subject.

rtg
-----------
Tim Gardner
Canonical, Inc