ACK: [SRU Focal/Groovy 0/3] (LP: #1920995) selftests: bpf verifier fails after sanitize_ptr_alu fixes

Kelsey Skunberg kelsey.skunberg at canonical.com
Wed Mar 24 02:11:31 UTC 2021


LGTM. Thank you Thadeu!

Acked-by: Kelsey Skunberg <kelsey.skunberg at canonical.com>

On 2021-03-23 17:28:23 , Thadeu Lima de Souza Cascardo wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920995
> 
> [Impact]
> bpf selftests will fail after applying fixes from 5.8.0-48 and 5.4.0-70.
> 
> [Fix]
> Apply selftests fixes and bpf verifier simplification and hardening.
> 
> [Test Plan]
> Ran the verifier test and other tests for the latest BPF fixes.
> 
> [Potential regression]
> BPF programs that worked before may stop working or, worse, programs that
> should not be allowed may start working.
> 
> Piotr Krysiuk (3):
>   bpf: Simplify alu_limit masking for pointer arithmetic
>   bpf: Add sanity check for upper ptr_limit
>   bpf, selftests: Fix up some test_verifier cases for unprivileged
> 
>  kernel/bpf/verifier.c                         | 21 +++++++++------
>  .../selftests/bpf/verifier/bounds_deduction.c | 27 +++++++++++++------
>  tools/testing/selftests/bpf/verifier/unpriv.c | 15 ++++++++++-
>  .../selftests/bpf/verifier/value_ptr_arith.c  | 23 +++++++++++++++-
>  4 files changed, 68 insertions(+), 18 deletions(-)
> 
> -- 
> 2.27.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list