NACK/Cmnt: [SRU] [Bionic][Xenial][PATCH 1/1] vmxnet3: Remove buf_info from device accessible structures

[Krzysztof Kozlowski]

On 23/03/2021 12:45, Krzysztof Kozlowski wrote:
> 
> On 23/03/2021 10:29, Stefan Bader wrote:
>> On 22.03.21 18:28, Ronak Doshi wrote:
>>>
>>> On 3/22/21, 5:38 AM, "Stefan Bader" <stefan.bader at canonical.com> wrote:
>>>
>>>> The bug asks for this to be included in all releases, Why restrict this to
>>>> Xenial and Bionic only. Also the patch is upstream
>>>>
>>>>     commit de1da8bcf40564a2adada2d5d5426e05355f66e8
>>>>     Author: Ronak Doshi <doshir at vmware.com>
>>>>     Date:   Wed Jan 27 18:08:16 2021 -0800
>>>>
>>>>          vmxnet3: Remove buf_info from device accessible structures
>>>>
>>>>     so this should be a cherry pick / backport submission. Finally the cover email
>>>>     and the patch were sent as individual emails and not as reply to the cover email
>>>>     which makes it had to keep things together.
>>>>
>>>>     -Stefan
>>>
>>> Hi Stefan,
>>>
>>> I am not sure of the process here. I usually raise a bug and the patches are ported to the
>>> kernels. This time I was asked to send the patch to this mailing list. Yes, the patch is upstream.
>>> Could you apply the patch to appropriate kernels or let me know what the next steps should be?
>>
>> Hi Ronak,
>>
>> there would be two options depending on urgency. If timing is less important and 
>> things are applicable for upstream stable kernels as well then getting things 
>> there will flow back into the Ubuntu kernels as well.
>>
>> For direct submission, we need to consider it for every supported release 
>> (including the upcoming one). The patch format should be that of a cherry-pick 
>> -x (meaning to have a cherry picked from ...) line before the additional signed 
>> off by. It would be backported from if it does not apply cleanly. Additionally 
>> there should be a line
>>
>> BugLink: https://bugs.launchpad.net/bugs/xxx


Hi Ronak,

Could you explain why is it needed on Xenial kernel (v4.4)? I understand
that the fix is important for VM guests using AMD SEV or Intel TDX. The
v4.4 Xenial kernel does not support these features (if I am not mistaken).

Best regards,
Krzysztof