[F/G/H][PATCH v3 0/3] Mute/Mic-mute LEDs are not work on HP 850/840/440 G8 Laptops

Jeremy Szu jeremy.szu at canonical.com
Tue Mar 23 10:17:30 UTC 2021


Hi Stefan,

Sorry for repeatedly sending the patches.
In v1 version, those patches got the NACK because of failing to apply to F/G.
In v2 version, I got the NACK again because without the BugLink in the patchs.
Therefore, I submitted the v3 for fixing the previous failure.

On Tue, Mar 23, 2021 at 4:17 PM Stefan Bader <stefan.baderæ–¼canonical.com> wrote:
>
> On 23.03.21 08:55, Jeremy Szu wrote:
> >
> > BugLink: https://bugs.launchpad.net/bugs/1920030
> >
> > [Impact]
> > The Mute/Mic-mute LEDs are not work when muting audio-output/microphone on HP 850/840/440 G8 laptops.
> >
> > [Fix]
> > Add three realtek quirks for them.
> >
> > [Test]
> > After applying the quirks, the LEDs are functioned on HP 850/840/440 G8 laptops.
> >
> > [Where problems could occur]
> > If HP ships the different system boards design with the same subsystem IDs of audio codec which are using different GPIO pins (different layout), then the quirks will not work (LEDs will not function when muting audio-output or microphone.
> >
> > Jeremy Szu (3):
> >    ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
> >    ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
> >    ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8
> >
> >   sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> Any reason you send the patches repeatedly for H/G/F while all of them claim to
> be cherry picks?
>
> -Stefan
>


-- 
Sincerely,
Jeremy Su



More information about the kernel-team mailing list