NACK: [RESEND][PATCH 0/1][SRU][F] Dynamically set AD5593R channel modes

[Kelsey Skunberg]

Plans for a v2 to be sent later. Thank you! 

-Kelsey

On 2021-01-13 11:33:17 , AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1895612
> 
> [Impact]
> On Advantech UNO-420 development platform, we need a generic way to set
> the pin mode.
> Upstream would like us to leverage ACPI override method to change the
> modes, but in Ubuntu core, we can't generate a new initramfs and boot up
> with the generated initramfs.
> 
> [Fix]
> Add a module parameter to assign pin modes while loading ad5593r driver.
> 
> [Test]
> Verified on Advantech UNO-420 platform.
> 
> [Where problems could occur]
> It checks the length of the passed parameter, and checks every bytes
> in it to make sure it's a valid argument. There should be no index out
> of range issue, and no wrong pin mode would be set.
> 
> William Sung (1):
>   UBUNTU: SAUCE: iio: dac: ad5593r: Dynamically set AD5593R channel
>     modes
> 
>  drivers/iio/dac/ad5592r-base.c | 21 +++++++++++++---
>  drivers/iio/dac/ad5592r-base.h |  4 ++++
>  drivers/iio/dac/ad5593r.c      | 44 ++++++++++++++++++++++++++++++++++
>  3 files changed, 66 insertions(+), 3 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team