ACK: [F/G/H][Unstable][SRU][PATCHv2 0/1] selftests/powerpc: Make the test check in eeh-basic.sh posix compliant

Guilherme Piccoli gpiccoli at canonical.com
Fri Mar 12 12:45:24 UTC 2021


On Fri, Mar 12, 2021 at 5:20 AM Po-Hsu Lin <po-hsu.lin at canonical.com> wrote:
>
> [Impact]
> The fail check in the end of powerpc/eeh/eeh-basic.sh script will complain about "unexpected operator"
>
> This is caused by the following line in the script:
>   $ test "$failed" == 0
>   /bin/sh: 4: test: 0: unexpected operator
>
> [Fix]
> * 3db380570af705 ("selftests/powerpc: Make the test check in eeh-basic.sh posix compliant")
>
> This is affecting F/G/H and can be cherry-picked for all of them.
>
> [Test case]
> Run the eeh-basic.sh script in tools/testing/selftests/powerpc/eeh/
> This error message should be gone.
>
> [Where problems could occur]
> This fix is limited to PowerPC testing tool, it's unlike to cause any issue.
>
> Po-Hsu Lin (1):
>   selftests/powerpc: Make the test check in eeh-basic.sh posix compliant
>
>  tools/testing/selftests/powerpc/eeh/eeh-basic.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --

Thanks Po-Hsu Lin, LGTM:

Acked-by: Guilherme G. Piccoli <gpiccoli at canonical.com>



More information about the kernel-team mailing list