ACK: [PATCH 0/3][SRU][U/OEM-5.10] support RTL8821CE RFE Type 2

Andrea Righi andrea.righi at canonical.com
Fri Mar 5 11:58:19 UTC 2021


On Thu, Mar 04, 2021 at 02:15:47PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1885862
> 
> [Impact]
> 
> RTL8821CE RFE Type 2 PCIE module is not supported by new rtw88 driver
> in kernel version v5.11 or older. Dmesg gives:
> 
>   rtw_8821ce 0000:01:00.0: enabling device (0000 -> 0003)
>   rtw_8821ce 0000:01:00.0: Firmware version 24.8.0, H2C version 12
>   rtw_8821ce 0000:01:00.0: rfe 2 isn't supported
>   rtw_8821ce 0000:01:00.0: failed to setup chip efuse info
>   rtw_8821ce 0000:01:00.0: failed to setup chip information
> 
> Such modules are previosly covered by rtl8821ce-dkms.
> 
> [Fix]
> 
> Patch set
> https://lore.kernel.org/linux-wireless/20210202055012.8296-1-pkshih@realtek.com/
> landed in v5.12-rc1, as well as WLAN firmware updates in commit
> c5e3240eff0f ("rtw88: RTL8821C: Update firmware to v24.8"), which is
> already available in Hirsute version 1.195. Bluetooth firmware should
> have been the latest 0x829a_7644 in both Focal/Hirsute.
> 
> [Test Case]
> 
> With patched kernel, wlan interface should be up and running:
> 
>   rtw_8821ce 0000:01:00.0: enabling device (0000 -> 0003)
>   rtw_8821ce 0000:01:00.0: Firmware version 24.8.0, H2C version 12
>   rtw_8821ce 0000:01:00.0 wlp1s0: renamed from wlan0
> 
> [Where problems could occur]
> 
> Previously this hardware piece can only be driven by external DKMS
> modules, so with this driver patched, users can now use in-tree driver,
> but may experience the difference between them in power consumption or
> feature supportness.
> 
> [Other Info]
> 
> While Bionic/Focal LTS is still using rtl8821ce-dkms for RFE Type 2
> cards, there is no plan to introduce such change to them. So they'll be
> upgraded only at the next point release with kernel >= 5.11.

If this allows to deprecate a dkms in the future, I'm all for it! And
the patches look good (and it's all upstream stuff), therefore:

Acked-by: Andrea Righi <andrea.righi at canonical.com>



More information about the kernel-team mailing list