ACK: [PATCH] UBUNTU: [Packaging] Do not allow update-version-dkms to be run on a derivative kernel

Thadeu Lima de Souza Cascardo cascardo at canonical.com
Thu Mar 4 21:30:06 UTC 2021


On Thu, Mar 04, 2021 at 01:00:08PM -0700, Tim Gardner wrote:
> It is too easy to run this script when drifting through the cranky cheat sheet
> without really thinking about what you're doing while cranking a derivative
> kernel.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>

> ---
>  update-version-dkms | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/update-version-dkms b/update-version-dkms
> index d90ce2c85f65..cfff38531275 100755
> --- a/update-version-dkms
> +++ b/update-version-dkms
> @@ -19,6 +19,14 @@ esac
>  # find our changelog.
>  debian=$(awk -F= '($1 == "DEBIAN") { print $2 }' <debian/debian.env)
>  
> +# Make sure this isn't a derivative kernel
> +uconf=$debian/etc/update.conf
> +if [ -f $uconf ]
> +then
> +	echo "Do not run this script on a derivative kernel."
> +	exit 1
> +fi
> +
>  # identify the current series
>  series=$(dpkg-parsechangelog -l"$debian/changelog" -SDistribution)
>  if [ "$series" = "UNRELEASED" ]; then
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list