NACK: [PATCH] UBUNTU: [Packaging] Do not allow update-version-dkms to be run on a derivative kernel

[Thadeu Lima de Souza Cascardo]

On Thu, Mar 04, 2021 at 09:16:38AM -0700, Tim Gardner wrote:
> It is too easy to run this script when drifting through the cranky cheat sheet
> without really thinking about what you're doing while cranking a derivative
> kernel.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
> 
> v2 - use debian.DERIVATIVE/etc/update.conf to determine if this is a master
>      dependent derivative.
> 
>  update-version-dkms | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/update-version-dkms b/update-version-dkms
> index d90ce2c85f65..70158d3c6127 100755
> --- a/update-version-dkms
> +++ b/update-version-dkms
> @@ -19,6 +19,17 @@ esac
>  # find our changelog.
>  debian=$(awk -F= '($1 == "DEBIAN") { print $2 }' <debian/debian.env)
>  
> +# Make sure this isn't a derivative kernel
> +uconf=$debian/etc/update.conf
> +if [ -f $uconf ]
> +then
> +	if egrep -q "DEBIAN_MASTER=debian\.master" $uconf
> +	then

We have derivatives of derivatives, like xenial/linux-azure, which has
debian.azure-4.15 as DEBIAN_MASTER.

Cascardo.

> +		echo "Do not run this script on a derivative kernel."
> +		exit 1
> +	fi
> +fi
> +
>  # identify the current series
>  series=$(dpkg-parsechangelog -l"$debian/changelog" -SDistribution)
>  if [ "$series" = "UNRELEASED" ]; then
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team