ACK: [PATCH 0/3][SRU][U/OEM-5.10] support RTL8821CE RFE Type 2

[Tim Gardner]

On 3/3/21 11:15 PM, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1885862
> 
> [Impact]
> 
> RTL8821CE RFE Type 2 PCIE module is not supported by new rtw88 driver
> in kernel version v5.11 or older. Dmesg gives:
> 
>    rtw_8821ce 0000:01:00.0: enabling device (0000 -> 0003)
>    rtw_8821ce 0000:01:00.0: Firmware version 24.8.0, H2C version 12
>    rtw_8821ce 0000:01:00.0: rfe 2 isn't supported
>    rtw_8821ce 0000:01:00.0: failed to setup chip efuse info
>    rtw_8821ce 0000:01:00.0: failed to setup chip information
> 
> Such modules are previosly covered by rtl8821ce-dkms.
> 
> [Fix]
> 
> Patch set
> https://lore.kernel.org/linux-wireless/20210202055012.8296-1-pkshih@realtek.com/
> landed in v5.12-rc1, as well as WLAN firmware updates in commit
> c5e3240eff0f ("rtw88: RTL8821C: Update firmware to v24.8"), which is
> already available in Hirsute version 1.195. Bluetooth firmware should
> have been the latest 0x829a_7644 in both Focal/Hirsute.
> 
> [Test Case]
> 
> With patched kernel, wlan interface should be up and running:
> 
>    rtw_8821ce 0000:01:00.0: enabling device (0000 -> 0003)
>    rtw_8821ce 0000:01:00.0: Firmware version 24.8.0, H2C version 12
>    rtw_8821ce 0000:01:00.0 wlp1s0: renamed from wlan0
> 
> [Where problems could occur]
> 
> Previously this hardware piece can only be driven by external DKMS
> modules, so with this driver patched, users can now use in-tree driver,
> but may experience the difference between them in power consumption or
> feature supportness.
> 
> [Other Info]
> 
> While Bionic/Focal LTS is still using rtl8821ce-dkms for RFE Type 2
> cards, there is no plan to introduce such change to them. So they'll be
> upgraded only at the next point release with kernel >= 5.11.
> 
> Guo-Feng Fan (3):
>    rtw88: coex: 8821c: correct antenna switch function
>    rtw88: 8821c: Correct CCK RSSI
>    rtw88: 8821c: support RFE type2 wifi NIC
> 
>   drivers/net/wireless/realtek/rtw88/main.c     |   2 +
>   drivers/net/wireless/realtek/rtw88/main.h     |   7 +
>   drivers/net/wireless/realtek/rtw88/rtw8821c.c | 109 ++++-
>   drivers/net/wireless/realtek/rtw88/rtw8821c.h |  22 +
>   .../wireless/realtek/rtw88/rtw8821c_table.c   | 397 ++++++++++++++++++
>   .../wireless/realtek/rtw88/rtw8821c_table.h   |   1 +
>   6 files changed, 525 insertions(+), 13 deletions(-)
> 

Acked-by: Tim Gardner <tim.gardner at canonical.com>
-----------
Tim Gardner
Canonical, Inc