ACK w/cmt: [PATCH 0/2][SRU][GROOVY][RISCV] Revert SiFive Unleashed CPUFreq (LP: #1917433
Tim Gardner
tim.gardner at canonical.com
Tue Mar 2 12:53:38 UTC 2021
On 3/2/21 4:19 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> == SRU Justifcation Groovy/Hirsute RISCV ==
>
> The SiFive Unleashed board with the current Ubuntu cpufreq default
> config can hang on boot with CPU freq enabled with the latest device
> tree settings. It is known that the cpufreq can be problematic so
> the recommended way forward is to currently revert the cpufreq
> enablement commit.
>
> commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1
> Author: David Abdurachmanov <david.abdurachmanov at sifive.com>
> Date: Tue Jan 28 02:55:56 2020 -0800
>
> SiFive Unleashed CPUFreq
>
> == The fix(es) ==
>
> Revert commit "SiFive Unleashed CPUFreq"
>
> == Test Case ==
>
> Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot.
>
> == Where problems could occur ==
>
> Users expecting CPU freq scaling now don't have this working option.
> This is deemed to be acceptable as without the fix their systems are
> likely to be unbootable with the updated DT.
>
> Colin Ian King (2):
> Revert "SiFive Unleashed CPUFreq"
> UBUNTU: [Config] Update annotations for CPUFreq revert
>
> arch/riscv/Kconfig | 8 -----
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 ---
> .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 -------------------
> arch/riscv/configs/defconfig | 5 ---
> debian.riscv/config/annotations | 3 +-
> 5 files changed, 2 insertions(+), 53 deletions(-)
>
Shouldn't these 2 patches be applied in the reverse order in which they
are presented to preserve bisectibility ? Otherwise:
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-----------
Tim Gardner
Canonical, Inc
More information about the kernel-team
mailing list