ACK: [SRU][H][PATCH 0/1] Fix net kselftest tls.bidir test case failure

[Andrea Righi]

On Tue, Jun 22, 2021 at 03:31:36PM -0500, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1933268
> 
> [Impact]
> 
> The tls bidir test from the network kselftests fails with the ChaCha
> cipher:
> 
>  # RUN tls.12_chacha.bidir ...
>  # tls.c:845:bidir:Expected ret (-1) == 0 (0)
>  # bidir: Test terminated by assertion
>  # FAIL tls.12_chacha.bidir
> 
> This is a problem with the test. The test fixture setup configures tls
> in one direction on the test socket pair according to the cipher being
> tested. The test case configures tls in the other direction, however it
> always configures for GCM regardless of the cipher being tested. When
> the test cipher is ChaCha the setsockopt() calls fail as the cipher is
> required to be the same in both directions.
> 
> [Test Plan]
> 
> Run the tls test from the net kselftests and confirm that the bidir test
> now passes when the test cipher is ChaCha.
> 
> [Where problems could occur]
> 
> This is a fix for a test case and should have no user impact. A serious
> problem in the test case might cause passing test cases to fail or
> prevent subsequent test cases from running. Any such issues should be
> caught during testing in -proposed before releasing kernels to users.
> 
> Thanks,
> Seth

Looks good to me, thanks!

Acked-by: Andrea Righi <andrea.righi at canonical.com>