ACK/Cmnt: [PATCH][U] UBUNTU: SAUCE: selftests: seccomp: bump up timeout to 5min

[Andrea Righi]

On Wed, Jun 16, 2021 at 06:19:29PM -0300, Guilherme Piccoli wrote:
> On Wed, Jun 16, 2021 at 6:12 AM Andrea Righi <andrea.righi at canonical.com> wrote:
> >
> >  DEBUG| [stdout] # selftests: seccomp: seccomp_benchmark
> >  DEBUG| [stdout] # net.core.bpf_jit_enable = 1
> >  DEBUG| [stdout] # net.core.bpf_jit_harden = 0
> >  DEBUG| [stdout] #
> >  DEBUG| [stdout] not ok 2 selftests: seccomp: seccomp_benchmark # TIMEOUT 120 seconds
> >
> > This test can easily fail if the testing environment is a bit
> > overloaded, so bump up the timeout to 5min to prevent false positive
> > failures.
> >
> > Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
> > ---
> >  tools/testing/selftests/seccomp/settings | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/seccomp/settings b/tools/testing/selftests/seccomp/settings
> > index 6091b45d226b..694d70710ff0 100644
> > --- a/tools/testing/selftests/seccomp/settings
> > +++ b/tools/testing/selftests/seccomp/settings
> > @@ -1 +1 @@
> > -timeout=120
> > +timeout=300
> 
> Thank you Andrea! I've seen similar timeouts, I think on Hirsute (or
> maybe Groovy?) testing. Is there a reason to not have it in previous
> releases?

I guess we can hit the same timeout issue also with the other kernels,
the failures are mostly caused by overcommitting/overloading the testing
environment (VMs running concurrently on the same physical hosts).

Ideally it'd be nice to have this fix applied upstream and then
cherry-pick the commit, let me see if we can get this applied upstream.

-Andrea

> The change itself looks good to me:
> 
> Acked-by: Guilherme G. Piccoli <gpiccoli at canonical.com>