ACK: [SRU][F][PATCH 0/8] UBUNTU: SAUCE: Revert upstream 'module' patches that removed exported symbols

Kamal Mostafa kamal at canonical.com
Tue Jun 15 22:17:45 UTC 2021


LGTM.

Acked-by: Kamal Mostafa <kamal at canonical.com>

 -Kamal

On Tue, Jun 15, 2021 at 05:04:00PM -0500, Ian May wrote:
> BugLink: http://bugs.launchpad.net/bugs/1932065
> 
> SRU Justification:
> 
> [Impact]
> 
> * The following patches removed an exported symbol that will cause potential disruption and breakage for customers
> 
>  modules: inherit TAINT_PROPRIETARY_MODULE
>  modules: return licensing information from find_symbol
>  modules: rename the licence field in struct symsearch to license
>  modules: unexport __module_address
>  modules: unexport __module_text_address
>  modules: mark each_symbol_section static
>  modules: mark find_symbol static
>  modules: mark ref_module static
> 
> [Fix]
> 
> * Temporarily revert as SAUCE patches to allow customers time to make necessary changes to support eventual patch changes.
> 
> [Test Plan]
> 
> * none
> 
> [Where problems could occur]
> 
> * The new functionality provided by patches will be removed, since we aren't removing existing functionality the risk should be low.
> 
> Ian May (8):
>   UBUNTU: SAUCE: Revert "modules: inherit TAINT_PROPRIETARY_MODULE"
>   UBUNTU: SAUCE: Revert "modules: return licensing information from
>     find_symbol"
>   UBUNTU: SAUCE: Revert "modules: rename the licence field in struct
>     symsearch to license"
>   UBUNTU: SAUCE: Revert "modules: unexport __module_address"
>   UBUNTU: SAUCE: Revert "modules: unexport __module_text_address"
>   UBUNTU: SAUCE: Revert "modules: mark each_symbol_section static"
>   UBUNTU: SAUCE: Revert "modules: mark find_symbol static"
>   UBUNTU: SAUCE: Revert "modules: mark ref_module static"
> 
>  include/linux/module.h | 26 +++++++++++++++---
>  kernel/module.c        | 60 ++++++++++++------------------------------
>  2 files changed, 40 insertions(+), 46 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list