NAK: [SRU][F:linux-bluefield][PATCH v2 0/3] Updates to mlx-bootctl

[Tim Gardner]

See comments inline. Overall, the split looks good, but I think you've 
got a couple areas that need improvement.

On 6/15/21 3:25 AM, Shravan Kumar Ramani wrote:
> v1 --> v2
> Split single patch into 3 separate patches based on functionality as suggested.
> 
> 1. Support VPD info in EEPROM MFG
> BugLink: https://bugs.launchpad.net/bugs/1931843
> SRU Justification:
> 
> [Impact]
> The EEPROM MFG partition on BlueField-2 has been updated to include the VPD information for each card. In order to access these newly added fields, the mlx-bootctl driver needs to be updated to provide an access mechanism.
> 
> [Fix]
> Add support for VPD fields in the EEPROM MFG and provide access to these via sysfs entries. The newly added sysfs entries are: sku (SKU ID), modl (Model Number), sn (Serial Number) and uuid (UUID). And the previously added opn_str sysfs has been renamed to opn.
> 
> [Test Case]
> Though the driver provides read and write access through sysfs, the contents of the MFG partition are written during Manufacturing and then locked in order to protect the info. Writing to this partition will therefore require resetting the MFG info from the UEFI Device Manager, which will unlock the partition and allow for it to be reprogrammed.
> Reading the sysfs entries will print the contents of each field. It could also be empty if the field was not programmed earlier.
> 
> [Regression Potential]
> Can be considered minimum, since the new fields have been added without interfering with the existing fields which might already be present in the EEPROM.
> 
> 2. Fix potential buffer overflow
> BugLink: https://bugs.launchpad.net/bugs/1931981
> SRU Justification:
> 
> [Impact]
> The sysfs store/show functions use sprintf without specifying a size which could lead to potential buffer overflow.
> 
> [Fix]
> Replace sprintf with snprintf to avoid buffer overflow. Also, remove the redundant strlen usage since count is already available in the _store functions.
> 
> [Test Plan]
> Read/write access to the EEPROM MFG fields can be tested via the sysfs entries that are exposed by the driver. Please note that the MFG partition is locked in order to protect the data and this could block all writes to it. In order to enable writes to the EEPROM, the MFG Info needs to be reset via the UEFI Device Manager.
> 
> [Regression Potential]
> Can be considered minimum.
> 
> 3. Update license and version info
> BugLink: https://bugs.launchpad.net/bugs/1931984
> SRU Justification:
> 
> [Impact]
> License info needs to be updated since the current info is no longer accurate.
> Driver version needs to be incremented since new features have been added.
> 
> [Fix]
> Update license info to "Dual BSD/GPL".
> Increment version to 1.4
> 
> [Test Plan]
> Verify version change
> 
> [Regression Potential]
> None
> 
> Shravan Kumar Ramani (3):
>    UBUNTU: SAUCE: mlx-bootctl: Support VPD info in EEPROM MFG
>    UBUNTU: SAUCE: mlx-bootctl: Fix potential buffer overflow
>    UBUNTU: SAUCE: mlx-bootctl: Update license and version info
> 
>   drivers/platform/mellanox/mlx-bootctl.c | 353 ++++++++++++++++++------
>   1 file changed, 270 insertions(+), 83 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc