[PATCH 3/7][SRU][OEM-5.10] platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure

AceLan Kao acelan.kao at canonical.com
Thu Jun 10 06:47:50 UTC 2021

From: Hans de Goede <hdegoede at redhat.com>

BugLink: https://bugs.launchpad.net/bugs/1931509

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi at dell.com>
Cc: Mario Limonciello <mario.limonciello at dell.com>
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
(cherry picked from commit f4c4e9ad1523a32a78f5caf68f1b346a30035481)
Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao at canonical.com>
 drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
index c40d5658c7c42..8bc44316648ff 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
@@ -498,7 +498,6 @@ static int init_bios_attributes(int attr_type, const char *guid)
-	release_attributes_data();
 	return retval;

More information about the kernel-team mailing list