NACK/Cmnt: [linux-uc20-efi][FOCAL][PATCH 2/2] UBUNTU: [Packaging] automatically detect flavours from build-deps

[Stefan Bader]

On 08.06.21 13:56, Dimitri John Ledkov wrote:
> Automatically detected from build-deps which flavours to build
> kernel.efi apps for. This means that suffixes of
> linux-image-unsigned-$(ABI)-* are used to determine the desired
> flavours.
> 
> If this parsing becomes insufficient, it might need to be updated to
> use python-apt in the future, or encode flavours in
> $(debian)/flavors.mk or some such.
> 
> This makes it trivial to build derivative kernel.efi apps, by simply
> adjusting appropriate control.stub with the desired flavour
> build-deps.
> 
> BugLink: https://bugs.launchpad.net/bugs/1931242
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> ---
>   debian/rules | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/rules b/debian/rules
> index f6e6ec0..18adb20 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -12,7 +12,7 @@ KERNEL_ABI_VERSION=$(shell echo "$(VERSION)" | sed -ne 's/\([0-9]*\.[0-9]*\.[0-9
>   
>   DEB_HOST_ARCH=$(shell dpkg-architecture -qDEB_HOST_ARCH)
>   
> -FLAVOURS=generic lowlatency
> +FLAVOURS=$(shell sed -n 's/linux-image-unsigned-$(KERNEL_ABI_VERSION)-//p' debian/control | sed 's/[ ,]//g')

debian/control is a generated file. This will cause errors running clean after 
git clean -d -x -f and potentially could pick up the wrong flavours if there is 
a left over conrol. The latter might only be relevant once there are multiple 
efi intermediates since switching between normal kernels and those requires a 
git clean -d -x -f.

-Stefan
>   
>   clean: debian/control
>   	dh_testdir
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210609/47d8d929/attachment.sig>