ACK: [SRU][H][PATCH 0/1] install kvm_stat systemd service

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 6/2/21 10:07 AM, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921870
> 
> SRU Justification:
> 
> [Impact]
> 
> * Nice to have feature requested by IBM - a systemd service monitoring
>    KVM guests.
> * Adds a new systemd service, not enabled by default.
> 
> [Fix]
> 
> * Install the systemd .service file when installing linux-tools-host
> 
> [Test Plan]
> 
> * dpkg -c linux-tools-host_5.11.0-18.19_all.deb
>    ./lib/systemd/system/kvm_stat.service
> * Install the package and reboot
> * Check if kvm_stat is present and not active after reboot:
>    ls -l /lib/systemd/system/kvm_stat.service
>    systemctl -a | grep kvm_stat
> 
> [Where problems could occur]
> 
> * Service can be enabled and started by mistake or by any further future
>    Makefile change (enabling all services installed by linux-tools-host).
> 
> * The service logs into /var/log/kvm_stat.csv (not journal!) and package does
>    not provide logrotate by default, thus the logging could eat entire
>    disk space.
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (1):
>    UBUNTU: [Debian] install kvm_stat systemd service
> 
>   debian/rules.d/3-binary-indep.mk | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 

-- 
-----------
Tim Gardner
Canonical, Inc