NACK: [SRU] [Focal] [PATCH v3 0/4] qla2xxx: bug fixes
tim.gardner at canonical.com
Thu Jun 3 12:03:59 UTC 2021
Hi Nilesh - I hate to be tedious, but I couldn't get patch 2 or 3 to
apply to Focal tip. I was able to cherry-pick 2, but 3 still wouldn't apply.
Patch 4 backport is quite a bit different then the upstream commit. Have
you run this kernel on any other hosts with this storage adapter to make
sure there have been no regressions ? There is no indication in the bug
report. We really want to be careful since (I think) this is a common
device in the server world, i.e., cloud.
On 6/2/21 3:25 AM, Nilesh Javali wrote:
> BugLink: https://bugs.launchpad.net/bugs/1860724
> SRU Justification:
> * On Ubuntu 20.04, NVMe Target will not get discovered in N2N
> * configuration. The discovery was failing because Initiator was
> * trying FC PRLI instead of NVMe PRLI.
> * The driver code changes to handle NVMe N2N configuration and send PRLI
> * based on the target.
> [Test Plan]
> * Load driver in NVMe N2N configuration and NVMe devices should be
> * discovered by an Initiator.
> [Where problems could occur]
> * NVMe N2N configuration.
> [Other Info]
> * The bug is with inbox qla2xxx driver and needs update.
> * All the qla2xxx driver bug fixes are part of upstream kernel.
> * The repo used is,
> * https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal
> * The base-commit used to apply these bug fixes is at the bottom.
> - Updated cherry picked and backported commit details for each patch
> - Updated subject line to remove pull request
> - Add v3 and v2 change list to cover letter
> - Added SRU justification to cover letter
> - Updated subject line of each patch
> - Added mainline commit details for each patch
> Arun Easi (1):
> scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue
> Quinn Tran (2):
> scsi: qla2xxx: Serialize fc_port alloc in N2N
> scsi: qla2xxx: Set Nport ID for N2N
> Quinn Trann (1):
> scsi: qla2xxx: Fix N2N and NVMe connect retry failure
> drivers/scsi/qla2xxx/qla_def.h | 2 +
> drivers/scsi/qla2xxx/qla_init.c | 68 ++++++++++++++++++++++++++-------
> drivers/scsi/qla2xxx/qla_mbx.c | 47 ++++++++++++-----------
> drivers/scsi/qla2xxx/qla_os.c | 10 +++--
> 4 files changed, 88 insertions(+), 39 deletions(-)
> base-commit: b2b21184870d7b313573f1ad27d259adb27dc3af
More information about the kernel-team