APPLIED Re: [PATCH 0/1][SRU][OEM-5.10] intel/ipu6: remove test pattern generator

[Timo Aaltonen]

On 25.5.2021 9.18, You-Sheng Yang wrote:
> From: You-Sheng Yang <vicamo at gmail.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929157
> 
> [Impact]
> 
> Intel IPU6 camera driver includes a test pattern generator for early
> stage development before hardware ready. This driver exposes additional
> device nodes up to 24 of them as video devices. While Microsoft Teams,
> and maybe other video/camera apps as well, tries to locate a suitable
> device one by one, this may take up to minutes before returning to a
> usable state.
> 
> [Fix]
> 
> Intel resolved this by removing TPG in their kernel driver release
> Release_20210520
> (https://github.com/intel/ipu6-drivers/commit/362375c928d184fb0b4187df7da1ffd506bbd07f).
> 
> [Test Case]
> 
> Before this patch, there are 25 video devices on the testing platform.
> One additional is created by v4l2loopback. By removing TPG as this
> change does, the remaining video devices should be two exactly:
> 
>    $ ls -al /dev/video*
>    crw-rw----+ 1 root video 81, 0 May 25 02:08 /dev/video0
>    crw-rw----  1 root video 81, 1 May 25 02:08 /dev/video1
> 
> [Where problems could occur]
> 
> On this platform TPG is never used after hardware being enabled. So it's
> probably pretty safe to remove them.
> 
> [Other Info]
> 
> While Intel IPU6 driver is currently for oem-5.10 only and there is plan
> for newer kernels at the moment, only oem-5.10 is nominated.
> 
> Wang Yating (1):
>    UBUNTU: SAUCE: intel/ipu6: Remove unnecessary video devices
> 
>   drivers/media/pci/intel/ipu-isys-csi2-be.c | 325 ---------------------
>   drivers/media/pci/intel/ipu-isys-csi2-be.h |   3 -
>   drivers/media/pci/intel/ipu-isys-csi2.c    |  31 --
>   drivers/media/pci/intel/ipu-isys-tpg.c     | 311 --------------------
>   drivers/media/pci/intel/ipu-isys-tpg.h     |  99 -------
>   drivers/media/pci/intel/ipu-isys-video.c   |  10 -
>   drivers/media/pci/intel/ipu-isys-video.h   |   1 -
>   drivers/media/pci/intel/ipu-isys.c         |  77 -----
>   drivers/media/pci/intel/ipu-isys.h         |   5 +-
>   drivers/media/pci/intel/ipu-pdata.h        |   7 -
>   drivers/media/pci/intel/ipu6/Makefile      |   3 -
>   drivers/media/pci/intel/ipu6/ipu6-isys.c   | 144 ---------
>   drivers/media/pci/intel/ipu6/ipu6.c        |  26 +-
>   13 files changed, 2 insertions(+), 1040 deletions(-)
>   delete mode 100644 drivers/media/pci/intel/ipu-isys-csi2-be.c
>   delete mode 100644 drivers/media/pci/intel/ipu-isys-tpg.c
>   delete mode 100644 drivers/media/pci/intel/ipu-isys-tpg.h
> 


-- 
t