NACK: [SRU][F:linux-bluefield][PATCH] netfilter: flowtable: Free block_cb when being deleted

[Stefan Bader]

On 01.06.21 23:49, Daniel Jurgens wrote:
> 
> 
>> -----Original Message-----
>> From: Daniel Jurgens <danielj at nvidia.com>
>> Sent: Tuesday, May 18, 2021 4:42 PM
>> Subject: [SRU][F:linux-bluefield][PATCH] netfilter: flowtable: Free block_cb
>> when being deleted
>>
>> From: Roi Dayan <roid at mellanox.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1927252
>>
>> Free block_cb memory when asked to be deleted.
>>
>> Fixes: 978703f42549 ("netfilter: flowtable: Add API for registering to flow
>> table events")
>> Signed-off-by: Roi Dayan <roid at mellanox.com>
>> Reviewed-by: Paul Blakey <paulb at mellanox.com>
>> Reviewed-by: Oz Shlomo <ozsh at mellanox.com>
>> Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org> (backported from
>> commit bc8e71314e8444c6315c482441f3204c032ab327)
> 
> Resent with additional info about why it was backported

This NACK is not a reply to any previous submission. So there is no way to tell 
which thread to invalidate. Worse the new submissions seem to have no indication 
that they are resends (v2, v3, ...). And one of those patches had been submitted 
twice which caused further issues. I will now NACK all of those. Please re-send 
the two patches but update the subject to include a version:

eg. [SRU F:linux-bluefield][PATCH v2] ...

Thanks,
Stefan

> 
>> Signed-off-by: Daniel Jurgens <danielj at nvidia.com>
>>
>> ---
>>   net/netfilter/nf_flow_table_core.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/netfilter/nf_flow_table_core.c
>> b/net/netfilter/nf_flow_table_core.c
>> index 5144e31..0336117 100644
>> --- a/net/netfilter/nf_flow_table_core.c
>> +++ b/net/netfilter/nf_flow_table_core.c
>> @@ -427,10 +427,12 @@ void nf_flow_table_offload_del_cb(struct
>> nf_flowtable *flow_table,
>>
>>   	mutex_lock(&flow_table->flow_block_lock);
>>   	block_cb = flow_block_cb_lookup(block, cb, cb_priv);
>> -	if (block_cb)
>> +	if (block_cb) {
>>   		list_del(&block_cb->list);
>> -	else
>> +		flow_block_cb_free(block_cb);
>> +	} else {
>>   		WARN_ON(true);
>> +	}
>>   	mutex_unlock(&flow_table->flow_block_lock);
>>   }
>>   EXPORT_SYMBOL_GPL(nf_flow_table_offload_del_cb);
>> --
>> 1.8.3.1
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210602/2e8a7272/attachment.sig>