ACK/Cmnt: [SRU][F:linux-bluefield][PATCH 0/1] UBUNTU: SAUCE: Automate soft reset of BlueField ARM via GPIO7

[Stefan Bader]

On 26.05.21 19:42, Asmaa Mnebhi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1929736
> 
> SRU Justification:
> 
> [Impact]
> 
> The BlueSphere like boards have a feature where the BMC
> can trigger a BlueField ARM reset via ipmitool. The ipmitool
> command simply toggles the signal on a BMC GPIO pin which
> propagates to HOST GPIO 7. HOST GPIO 7 is setup as an
> interrupt for SW resetting ARM.
> 
> At the moment, the user needs to manually run bfacpievt
> script to create acpi files. These files are responsible for
> triggering a "reboot". This patch automates this process.
> Now, the reboot is entirely handled by the gpio driver.
> 
> [Fix]
> 
> * Remove the acpi event handler code and replace it with kernel emergency_restart
> 
> [Test Case]
> 
> * On BF-2 board with BMC (such as BlueSphere), trigger ARM reset via BMC ipmitool command.
> 
> [Regression Potential]
> 
> No known regression.
> 
The "no known regression" is hard to believe for anything. But also not quite 
what this section is trying to cover. The change adds an automated reboot 
mechanism. So the regression potential is that there might be unexpected 
reboots. This section should be an aid for testers what might be signs of 
something going wrong that is related to this individual change.

Regardless of that note:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210601/cf317723/attachment.sig>