[PATCH 2/2] Revert "drm/amd/amdgpu: fix refcount leak"

Stefan Bader stefan.bader at canonical.com
Wed Jul 28 15:02:30 UTC 2021


This reverts commit 6c0065eb69de90d50186c04f51ffe889e5bbe037. The 4.19.y
series which this patch comes from has a previous change which is not in
bionic which stores GEM info in the framebuffer. Suspecting that due to
this we actually have no refcount leak in our kernel.

Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
index cf001bb4adb6..90fa8e8bc6fb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
@@ -292,13 +292,10 @@ void amdgpu_fb_output_poll_changed(struct amdgpu_device *adev)
 static int amdgpu_fbdev_destroy(struct drm_device *dev, struct amdgpu_fbdev *rfbdev)
 {
 	struct amdgpu_framebuffer *rfb = &rfbdev->rfb;
-	int i;
 
 	drm_fb_helper_unregister_fbi(&rfbdev->helper);
 
 	if (rfb->obj) {
-		for (i = 0; i < rfb->base.format->num_planes; i++)
-			drm_gem_object_put(rfb->obj);
 		amdgpufb_destroy_pinned_object(rfb->obj);
 		rfb->obj = NULL;
 		drm_framebuffer_unregister_private(&rfb->base);
-- 
2.25.1




More information about the kernel-team mailing list