NAK: [PATCH 0/2][SRU][OEM-5.10/U] Add new PCI MMIO based thermal driver

You-Sheng Yang vicamo.yang at canonical.com
Wed Jul 21 08:01:11 UTC 2021


Replaced by v2 to correct nomination targets. It's oem-5.13. Not 5.10.

On 7/14/21 6:26 PM, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934741
> 
> [Impact]
> 
> On Intel Alder Lake platforms, processor thermal device provides an
> additional thermal zone TCPU_PCI that is based on a new PCI MMIO only
> driver.
> 
> [Fix]
> 
> Two upstream v5.14-rc1 commits to backport.
> 
> [Test Case]
> 
> $ lspci -vvnns 00:04.0
> 00:04.0 Signal processing controller [1180]: Intel Corporation Device
> [8086:461d] (rev 01)
>         Subsystem: Intel Corporation Device [8086:7270]
>         ...
> 
> # thermal_zones provided by the original driver
> $ cat /sys/devices/virtual/thermal/thermal_zone*/type
> acpitz
> INT3400 Thermal
> TCPU
> x86_pkg_temp
> 
> # thermal_zones provided by the new driver
> $ cat /sys/devices/virtual/thermal/thermal_zone*/type
> acpitz
> INT3400 Thermal
> TCPU
> TCPU_PCI
> x86_pkg_temp
> 
> [Where problems could occur]
> 
> These changes do not change existing interface to userspace, but add an
> additional thermal zone that doesn't involve ACPI method calls for use.
> 
> [Other Info]
> 
> ADL targets 5.13 kernel, so only Impish and oem-5.13 are nominated.
> 
> Srinivas Pandruvada (2):
>   thermal/drivers/int340x/processor_thermal: Split enumeration and
>     processing part
>   thermal/drivers/int340x/processor_thermal: Add PCI MMIO based thermal
>     driver
> 
>  .../thermal/intel/int340x_thermal/Makefile    |   3 +
>  .../intel/int340x_thermal/int3401_thermal.c   |  82 ++++
>  .../processor_thermal_device.c                | 289 ++------------
>  .../processor_thermal_device.h                |   8 +
>  .../processor_thermal_device_pci.c            | 371 ++++++++++++++++++
>  .../processor_thermal_device_pci_legacy.c     | 163 ++++++++
>  6 files changed, 658 insertions(+), 258 deletions(-)
>  create mode 100644 drivers/thermal/intel/int340x_thermal/int3401_thermal.c
>  create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
>  create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci_legacy.c
> 



More information about the kernel-team mailing list