ACK/Cmnt: [uc20 snap PATCH 0/4] snapcraft.yaml specify build base core20

Stefan Bader stefan.bader at canonical.com
Wed Jul 21 07:43:02 UTC 2021


On 20.07.21 15:31, Dimitri John Ledkov wrote:
> Set `build-base: core20` on focal based kernel snaps in
> snapcraft.yaml. This will allow both local snapcraft & launchpad
> auto-detect and select focal as the build host for our kernel
> snaps. This will also allow to remove "focal" series override from
> /+snap/ LP objects, making the /+snap/ settings modifyable with web-ui
> once again (as focal series option was only available over the API,
> not web-ui).
> 
> Providing patches for pc, pc-low-latency, pi, pi-test snaps. The most
> recently introduced intel snap already has this change applied.
> 
> Dimitri John Ledkov (1):
>    snapcraft.yaml: specify build-base core20
> 
>   snapcraft.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
I would omit *-test from patching. Those branches are meant to try out something 
(I believe they do not do automatic builds). Instead I would hope (not sure the 
ACL allows) that whoever has need of a test branch first moves it to the tip of 
the related real branch. So any updates land there.
But for the other changes:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210721/d13e9349/attachment.sig>


More information about the kernel-team mailing list