NACK: [PATCH 0/8][SRU][H] Fix garbage display when scrolling on TGL platforms

[Stefan Bader]

On 19.07.21 20:55, Tim Gardner wrote:
> These are all from linux-next and should be noted in the '(backported from...)" 
> line. Also, please describe what changes were required for the backport.
> 
Also to me adding that much change to i915 and then saying "should be fine" (not 
exactly those words) is hard to believe without a good explanation on how the 
changes try to avoid breaking a bunch of the older platforms. And Intel's 
history there is not the best...

-Stefan

> rtg
> 
> On 7/19/21 11:29 AM, chris.chiu at canonical.com wrote:
>> From: Chris Chiu <chris.chiu at canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1926579
>>
>> [Impact]
>> On Dell TGL platforms screen shows garbage when browsing website by scrolling 
>> mouse
>>
>> [Fix]
>> This patch fixes the issue
>> https://patchwork.freedesktop.org/patch/430153/?series=89348&rev=1
>> It needs dependant commits to be backported on top of Hirsute base. They 
>> define the stepping info and functions to access the stepping info so that the 
>> fix can specifically disable PSR2 when stepping is B1 from A0.
>>
>> [Test]
>> Verified on Dell TGL-H platforms.
>>
>> [Where problems could occur]
>> It disable PSR2 on A0 and B0 TGL-H platforms, should introduce no regression.
>>
>> Aditya Swarup (1):
>>    drm/i915/tgl: Use TGL stepping info for applying WAs
>>
>> Caz Yokoyama (1):
>>    drm/i915/adl_s: Add ADL-S platform info and PCI ids
>>
>> Gwan-gyeong Mun (1):
>>    drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0
>>
>> Jani Nikula (5):
>>    drm/i915: split out stepping info to a new file
>>    drm/i915: add new helpers for accessing stepping info
>>    drm/i915: switch KBL to the new stepping scheme
>>    drm/i915: switch TGL and ADL to the new stepping scheme
>>    drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP
>>
>>   drivers/gpu/drm/i915/Makefile                 |   1 +
>>   .../drm/i915/display/intel_display_power.c    |   7 +-
>>   drivers/gpu/drm/i915/display/intel_psr.c      |  14 ++-
>>   drivers/gpu/drm/i915/display/intel_sprite.c   |   2 +-
>>   drivers/gpu/drm/i915/gt/intel_lrc.c           |   2 +-
>>   drivers/gpu/drm/i915/gt/intel_workarounds.c   |  54 +++------
>>   drivers/gpu/drm/i915/i915_drv.c               |   3 +-
>>   drivers/gpu/drm/i915/i915_drv.h               |  97 ++++++----------
>>   drivers/gpu/drm/i915/i915_pci.c               |  13 +++
>>   drivers/gpu/drm/i915/intel_device_info.c      |   7 +-
>>   drivers/gpu/drm/i915/intel_device_info.h      |   5 +
>>   drivers/gpu/drm/i915/intel_pm.c               |  12 +-
>>   drivers/gpu/drm/i915/intel_step.c             | 106 ++++++++++++++++++
>>   drivers/gpu/drm/i915/intel_step.h             |  40 +++++++
>>   include/drm/i915_pciids.h                     |  11 ++
>>   15 files changed, 255 insertions(+), 119 deletions(-)
>>   create mode 100644 drivers/gpu/drm/i915/intel_step.c
>>   create mode 100644 drivers/gpu/drm/i915/intel_step.h
>>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210720/477a6910/attachment.sig>