NACK/cmt: [PATCH v3 1/1][SRU][H] drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

[Tim Gardner]

On 7/20/21 3:32 AM, Chris Chiu wrote:
> 
> 
> On Mon, Jul 19, 2021 at 10:29 PM Tim Gardner <tim.gardner at canonical.com 
> <mailto:tim.gardner at canonical.com>> wrote:
> 
>     Backports of more then simple complexity generally deserve some
>     explanation. In this case it looks like you've dropped a couple of
>     functions.
> 
> 
> In the v2 version, I did miss the code of intel_ddi_encoder_suspend and 
> shutdown, so I added them back in v3. In the v3 version, the dropped 
> function which causes unclean cherry-pick is skl_hpd_pin() which is 
> handled by the following commit which does not affect the TGL  models.
> 
> commit c8455098c67914c59d07f01819469e2e6f76f358
> Author: Lyude Paul <lyude at redhat.com <mailto:lyude at redhat.com>>
> Date:   Tue Feb 9 14:16:28 2021 -0500
> 
>      drm/i915/gen9_bc: Introduce HPD pin mappings for TGP PCH + CML combos
> 
> and intel_ddi_is_tc() from the following commit which could cause lots 
> of conflicts but we don't really need it for TGL model.
> commit 36ecb0ec105412aa7e7c89991a7cff90bf90b2f1
> Author: Ville Syrjälä <ville.syrjala at linux.intel.com 
> <mailto:ville.syrjala at linux.intel.com>>
> Date:   Fri Feb 5 23:46:26 2021 +0200
> 
>      drm/i915: Extract icl+ .{enable,disable}_clock() vfuncs
> Should I explain in the cover letter? Which part would be appropriate? 
> [Fix]? I'll propose a v4 with explanations. Thanks
> 

Typically backport changes are explained right after the '(backported 
from commit ...)' in the form:

[rtg - minor context adjustments]
or
[chris - dropped 2 functions to avoid backporting intrusive scaffolding 
patches]

rtg
-----------
Tim Gardner
Canonical, Inc