[SRU][H][PATCH v2 1/1] usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir

[Werner Sembach]

Am 16.07.21 um 17:30 schrieb Krzysztof Kozlowski:
> On 16/07/2021 17:12, Werner Sembach wrote:
>> Am 16.07.21 um 14:50 schrieb Greg Kroah-Hartman:
>>> On Fri, Jul 16, 2021 at 12:40:10PM +0200, Werner Sembach wrote:
>>>> From: Mario Limonciello <mario.limonciello at amd.com>
>>>>
>>>> BugLink: https://bugs.launchpad.net/bugs/1936583
>>>>
>>>> The XHCI controller is required to enter D3hot rather than D3cold for AMD
>>>> s2idle on this hardware generation.
>>>>
>>>> Otherwise, the 'Controller Not Ready' (CNR) bit is not being cleared by
>>>> host in resume and eventually this results in xhci resume failures during
>>>> the s2idle wakeup.
>>>>
>>>> Link: https://lore.kernel.org/linux-usb/1612527609-7053-1-git-send-email-Prike.Liang@amd.com/
>>>> Suggested-by: Prike Liang <Prike.Liang at amd.com>
>>>> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
>>>> Cc: stable <stable at vger.kernel.org> # 5.11+
>>>> Link: https://lore.kernel.org/r/20210527154534.8900-1-mario.limonciello@amd.com
>>>> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>>>> (cherry picked from commit d1658268e43980c071dbffc3d894f6f6c4b6732a)
>>>> Signed-off-by: Werner Sembach <wse at tuxedocomputers.com>
>>>> ---
>>>>   drivers/usb/host/xhci-pci.c | 7 ++++++-
>>>>   drivers/usb/host/xhci.h     | 1 +
>>>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>>>
>>> Any reason you resent us a patch that is already in a stable release?
>>>
>>> And why not just use the stable kernel trees as-is?  Why attempt to
>>> cherry-pick random portions of them?
>>>
>>> thanks,
>>>
>>> greg k-h
>> I didn't add the mailing list as recipent for my last replies so here again:
>>
>> I only checked the Ubuntu 5.11 tree where the patch is actually missing.
>>
>> The 5.8 kernel has other issues because of outdated amdgpu, that's why we never checked the 5.4 kernel.
>>
>> Testing for 5.4: often hangs on boot before display manager shows up
>>
>> 5.4 + amdgpu-dkms from here: https://www.amd.com/en/support/kb/release-notes/rn-amdgpu-unified-linux-21-20 : Hang on
>> boot issue gone, but does not suspend anymore, and has graphic glitches.
>>
>> Should I add these findings to the SRU?
> Hi Werner,
>
> This patch is specific to Ubuntu so it should not have been sent to LKML
> (stable, Greg and others), which you did. I guess that's what Greg meant.
>
> When sending such backports from your tree, be sure to set
> "suppresscc=all" in your .git/config or use appropriate argument for git
> send-email.
>
> Best regards,
> Krzysztof

Hi,

now I see, thanks for spelling it out, I was a little bit slow today. I 
didn't realize that git send-email added non Ubuntu mailings lists 
because of the cc in the commit message (besides already should know 
this because I did it once before by accident).

I'm really really sorry, for all the confusion I caused.

Kind regards

Werner Sembach