NAK: [SRU][F:linux-bluefield][Pull Request] Cherry-pick the upstreamed mlxbf-gige driver

[Tim Gardner]

Asmaa - your pull request looks fine, though the path should be:

git://git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield master-next

I have some comments about the last patch, "UBUNTU: SAUCE: Add code not 
included in upstreamed mlxbf-gige and gpio-mlxbf2". It looks like there 
are at least 4 distinct logical changes in that one patch. Surely they 
weren't applied originally in one big glob ? It should be split into 
multiple patches, each with a functional change. For example, there are 
macro changes, driver version change, module parameters added, 
exclusion, and irq handler changes. There is no way you can upstream 
that patch in its current form.

rtg

On 7/13/21 12:11 PM, Asmaa Mnebhi wrote:
> This pull request (23 commits) includes reverting all mlxbf-gige changes in
> linux-bluefield. Then it cherry-picks the newly upstreamed version of the
> mlxbf-gige driver. It also adds code that was left out in the upstreamed version
> and the code that was reverted in gpio-mlxbf2.c.
> 
> BugLink: https://bugs.launchpad.net/bugs/1934923
> 
> The pull request page can be found at:
> 
> https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds/+merge/405646
> 
> Git repo can be found at:
> 
> git+ssh://asmaam@git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield master-next
> 
> for you to fetch changes starting from commit cfabdc1ef2b73553a7ecc5908902cbaf290f4f4b
> 
>      Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.23 content"
> 
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>
> 
> Asmaa Mnebhi (22):
>    Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.23 content"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.21 content"
>    Revert "UBUNTU: SAUCE: Automate soft reset of BlueField ARM via GPIO7"
>    Revert "UBUNTU: SAUCE: Syncup with the latest gpio-mlxbf2 and
>      mlxbf-gige drivers"
>    Revert "Revert "UBUNTU: SAUCE: Fix intermittent OOB link up issue""
>    Revert "UBUNTU: SAUCE: Fix intermittent OOB link up issue"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_mdio.c: Support PHY interrupt on
>      Bluesphere"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Fix OOB PHY interrupt"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: use streaming DMA mapping for
>      packet buffers"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: address upstream comments on RX and
>      TX"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: remove gpio interrupt coalesce
>      resources"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add support for ndo_get_stats64"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: address some general upstream
>      comments"
>    Revert "UBUNTU: SAUCE: Address upstream comments from patch v6 for PHY
>      driver"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: cleanups from review"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: v5 patch cleanup and napi_schedule"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Fix OOB's ethtool command"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Support ethtool options"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: multiple fixes for stability"
>    Revert "UBUNTU: SAUCE: Remove built-in tests from mlxbf_gige driver"
>    Revert "UBUNTU: SAUCE: Add Mellanox BlueField Gigabit Ethernet driver"
>    UBUNTU: SAUCE: Add code not included in upstreamed mlxbf-gige and
>      gpio-mlxbf2
> 
> David Thompson (1):
>    Add Mellanox BlueField Gigabit Ethernet driver
> 
>   drivers/gpio/gpio-mlxbf2.c                    |  42 +---
>   .../net/ethernet/mellanox/mlxbf_gige/Kconfig  |   2 +-
>   .../net/ethernet/mellanox/mlxbf_gige/Makefile |  10 +-
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |  20 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |  11 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c     | 212 ++++++++++++++++++
>   .../mellanox/mlxbf_gige/mlxbf_gige_intr.c     |   3 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_main.c     |  72 +++---
>   .../mellanox/mlxbf_gige/mlxbf_gige_mdio.c     |   2 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     |   2 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_rx.c       |   8 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_tx.c       |   5 +-
>   12 files changed, 284 insertions(+), 105 deletions(-)
>   create mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
> 

-- 
-----------
Tim Gardner
Canonical, Inc