NACK/Cmnt: [SRU][F][PULL][PATCH v2 00/23] Cherry-pick the upstreamed mlxbf-gige driver

[Stefan Bader]

On 12.07.21 14:58, Asmaa Mnebhi wrote:
> I don't think anyone on our team has done this before so I would greatly appreciate you more input to implement this properly. I am not sure what a "pull request" involves in this case. I followed instructions from https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat

I cannot say whether those are in your team but at least it was from 
Mellanox/Nvidia email addresses and for bluefield:

https://lists.ubuntu.com/archives/kernel-team/2021-July/122239.html (Bodong Wang)
https://lists.ubuntu.com/archives/kernel-team/2021-May/120092.html (Daniel Jurgens)

And this was one of my earlier replies with some more info: 
https://lists.ubuntu.com/archives/kernel-team/2021-May/119815.html

-Stefan

> 
> Thanks,
> Asmaa
> 
> -----Original Message-----
> From: Tim Gardner <tim.gardner at canonical.com>
> Sent: Monday, July 12, 2021 7:39 AM
> To: Stefan Bader <stefan.bader at canonical.com>; Asmaa Mnebhi <asmaa at nvidia.com>; kernel-team at lists.ubuntu.com
> Cc: David Thompson <davthompson at nvidia.com>
> Subject: Re: NACK/Cmnt: [SRU][F][PULL][PATCH v2 00/23] Cherry-pick the upstreamed mlxbf-gige driver
> 
> Also, patch 23 should be "UBUNTU; SAUCE".
> 
> On 7/12/21 1:11 AM, Stefan Bader wrote:
>> On 09.07.21 21:08, Asmaa Mnebhi wrote:
>>> BugLink:
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug
>>> s.launchpad.net%2Fbugs%2F1934923&data=04%7C01%7Casmaa%40nvidia.co
>>> m%7C8db24f0b397241357f9808d94529a2e4%7C43083d15727340c1b7db39efd9ccc1
>>> 7a%7C0%7C0%7C637616867403480005%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
>>> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdat
>>> a=mz0ifN4vzf1Dl6bUU1xHZeAKVXMiVsI8956STRgBrpM%3D&reserved=0
>>>
>>> SRU Justification:
>>>
>>> [Impact]
>>>
>>> The mlxbf-gige driver has just been upstreamed so linux-bluefield
>>> needs to be synced up with what we have upstreamed.
>>> IMPORTANT: during testing, make sure the latest UEFI (bootloader) is
>>> loaded on top of these changes, otherwise both the gpio driver and
>>> mlxbf-gige driver will fail to load.
>>>
>>> [Fix]
>>>
>>> * reverted 20 commits related to the mlxbf-gige driver and 1 commit
>>> related to gpio-mlxbf2 driver since there are dependencies between them.
>>> * Cherry-picked f92e1869d74e1acc6551256eb084a1c14a054e19 from
>>> net-next branch. The upstreamed version of the GPIO driver removed
>>> the dependency between the mlxbf-gige driver and gpio-mlxbf2 driver.
>>> * added code that was left out of the upstreamed version. and added
>>> code that got reverted in gpio-mlxbf2.c
>>> * updated the UEFI ACPI table to reflect the above changes (so the
>>> bootloader and the linux drivers need to be in sync)
>>>
>>> [Test Case]
>>>
>>> * oob_net0 coming up after several SW_RESET or reboot
>>> * oob_net0 coming up after several powercycles
>>> * oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
>>> * rmmod/modprove mlxbf_gige several times
>>> * OOB PXE boot multiple times from UEFI menu
>>> * automate OOB PXE boot and do reboot
>>> * automate OOB PXE boot and do powercycle
>>> * Test that GPIO7 reset still works on BlueSphere like boards
>>>
>>> [Regression Potential]
>>>
>>> Any of the test cases above could be impacted due to these changes.
>>>
>> A patch submission does not become a pull request by calling it that
>> way in the subject. Check the examples done by some of your colleagues.
>>
>> -Stefan
>>
>>
> 
> --
> -----------
> Tim Gardner
> Canonical, Inc
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210713/a97e9e53/attachment.sig>