NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: Sync up mlxbf-gige with upstreamed version

Asmaa Mnebhi asmaa at nvidia.com
Fri Jul 9 15:44:24 UTC 2021


I did "git revert" all 20 commits. So I am wondering how to proceed now:

1) I assume I need to send one pull request for all 20 reverts?
2) Then send another request for the cherry-pick? 
3) where should we send the pull request to? We have been sending you all patches based on the focal repo/master-next branch (git clone git+ssh://<username>@git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-bluefield/+git/focal). The focal repo doesn’t have a remote canonical branch:
git remote -v
origin  git+ssh://asmaam@git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-bluefield/+git/focal (fetch)
origin  git+ssh://asmaam@git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-bluefield/+git/focal (push)

4) I will additionally create 2 patches and send them via the focal repo (git send-email .):
	- one for updating the gpio driver
	- one for adding some code in mlxbf-gige we left out in the upstreamed version

Thanks,
Asmaa

-----Original Message-----
From: Tim Gardner <tim.gardner at canonical.com> 
Sent: Thursday, July 8, 2021 10:27 AM
To: Asmaa Mnebhi <asmaa at nvidia.com>; kernel-team at lists.ubuntu.com
Cc: Meriton Tuli <meriton at nvidia.com>; Khoa Vo <khoav at nvidia.com>; David Thompson <davthompson at nvidia.com>
Subject: Re: NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: Sync up mlxbf-gige with upstreamed version

On 7/7/21 1:52 PM, Asmaa Mnebhi wrote:
> Hi Tim,
> 
> That would mean I would have to submit multiple patches:
> 1) revert all 20 changes (which is time consuming)
> 2) cherry-pick from upstreaming
> 3) create a separate patch for the gpio driver
> 4) create a patch to add some code we left out of the upstreamed 
> version
> 
> So I would prefer it if we could keep this one patch but if you still think it is better, I will do it.
> 

Indeed, I do think it is better. Otherwise a lot of potentially valuable change information gets buried.

rtg
-----------
Tim Gardner
Canonical, Inc


More information about the kernel-team mailing list