ACK/cmnt: [SRU][F:linux-bluefield][PATCH v2] net/sched: act_ct: fix err check for nf_conntrack_confirm
bodong at nvidia.com
Fri Jul 9 12:53:24 UTC 2021
On 7/9/2021 3:49 AM, Kleber Souza wrote:
> On 07.07.21 16:00, Bodong Wang wrote:
>> From: wenxu <wenxu at ucloud.cn>
>> BugLink: https://bugs.launchpad.net/bugs/1934819
>> The confirm operation should be checked. If there are any failed,
>> the packet should be dropped like in ovs and netfilter.
>> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
>> Signed-off-by: wenxu <wenxu at ucloud.cn>
>> Signed-off-by: David S. Miller <davem at davemloft.net>
>> (cherry picked from commit 8955b90c3cdad199137809aac8ccbbb585355913
>> Signed-off-by: Bodong Wang <bodong at nvidia.com>
>> Acked-by: Tim Gardner <tim.gardner at canonical.com>
> An ACK should not be carried forward by the submitter from one version
> of the patch to the next without an explicit consent. The issue with
> it is that a person which reviewed and acknowledged one version of a
> is not automatically acknowledging the follow-up submissions even if the
> changes made are the ones suggested by this person.
> For the kind of changes suggested by Tim Gardner on v1 a re-submission
> of the patch is not needed, we can add/change this kind of information
> while applying the patch.
> No need to resubmit this, we can fix it up when applying it.
> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
Got it, thanks for the info.
More information about the kernel-team