NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: Sync up mlxbf-gige with upstreamed version

Tim Gardner tim.gardner at canonical.com
Wed Jul 7 18:36:25 UTC 2021


I think the best way to do this is to revert all 20 of the 
drivers/net/ethernet/mellanox/mlxbf_gige SAUCE patches, then you should 
be able to cherry-pick f92e1869d74e1acc6551256eb084a1c14a054e19 ("Add 
Mellanox BlueField Gigabit Ethernet driver"). That will preserve the 
provenance of the patch and make it clear it came from upstream.

Your next submission should also be a pull request given the number of 
patches.

rtg

On 7/7/21 12:00 PM, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934923
> 
> SRU Justification:
> 
> [Impact]
> 
> The mlxbf-gige driver has just been upstreamed so linux-bluefield needs to be synced up with what we have upstreamed.
> 
> [Fix]
> 
> * Cleaned up the gige driver as instructed by maintainers
> * removed dependency between the mlxbf-gige driver and gpio-mlxbf2 driver
> * updated the UEFI ACPI table to reflect the above changes
> 
> [Test Case]
> 
> * oob_net0 coming up after several SW_RESET or reboot
> * oob_net0 coming up after several powercycles
> * oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
> * rmmod/modprove mlxbf_gige several times
> * OOB PXE boot multiple times from UEFI menu
> * automate OOB PXE boot and do reboot
> * automate OOB PXE boot and do powercycle
> * Test that GPIO7 reset still works on BlueSphere like boards
> 
> [Regression Potential]
> 
> Any of the test cases above could be impacted due to these new changes.
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list