ACK: [SRU][G][H][I][UNSTABLE][PATCH 1/1] selftests/ftrace: fix event-no-pid on 1-core machine

[Stefan Bader]

On 05.07.21 17:47, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1927749
> 
> When running event-no-pid test on small machines (e.g. cloud 1-core
> instance), other events might not happen:
> 
>      + cat trace
>      + cnt=0
>      + [ 0 -eq 0 ]
>      + fail No other events were recorded
>      [15] event tracing - restricts events based on pid notrace filtering [FAIL]
> 
> Schedule a simple sleep task to be sure that some other process events
> get recorded.
> 
> Fixes: ebed9628f5c2 ("selftests/ftrace: Add test to test new set_event_notrace_pid file")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Acked-by: Steven Rostedt (VMware) <rostedt at goodmis.org>
> Signed-off-by: Shuah Khan <skhan at linuxfoundation.org>
> (cherry picked from commit 07b60713b57a8f952d029a2b6849d003d9c16108)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>   .../testing/selftests/ftrace/test.d/event/event-no-pid.tc  | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> index e6eb78f0b954..9933ed24f901 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc
> @@ -57,6 +57,10 @@ enable_events() {
>       echo 1 > tracing_on
>   }
>   
> +other_task() {
> +    sleep .001 || usleep 1 || sleep 1
> +}
> +
>   echo 0 > options/event-fork
>   
>   do_reset
> @@ -94,6 +98,9 @@ child=$!
>   echo "child = $child"
>   wait $child
>   
> +# Be sure some other events will happen for small systems (e.g. 1 core)
> +other_task
> +
>   echo 0 > tracing_on
>   
>   cnt=`count_pid $mypid`
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210706/5e760008/attachment-0001.sig>