ACK/Cmnt: [SRU][H][PULL v2] Update SmartPQI driver

[Stefan Bader]

On 05.07.21 14:43, Krzysztof Kozlowski wrote:
> Hi,
> 
> BugLink: https://bugs.launchpad.net/bugs/1933518
> 
> [Changes since v1]
> 1. Include missing "scsi: smartpqi: Add support for new product ids" (first
>     patch).
> 
> [Impact]
> 
> * Microchip asks to update the SCSI SmartPQI driver to latest version
>    from upstream Linux kernel.
> * This contains mostly fixes and refactorings.
> * Updated driver allows to support properly latest SmartPQI controllers.
> 
> [Fix]
> 
> * Cherry-pick all the patches related to smartpqi.
> * These are clean picks although the patchset is pretty big.
> 
> [Test Plan]
> 
> * Build-test each commit.
> * Asked Microhip to perform the testing. Received feedback:
>    "I installed the provided kernel package and thus far performed:
>    1. reboot tests
>    2. insmod/rmmod tests
>    3. fio testing: no performance regressions"
> 
> [Where problems could occur]
> 
> * The patches touch only smartpqi driver so the scope of possible
>    failures is limited to systems which probe it (so basically systems
>    with SmartPQI controller).
> * On such SmartPQI-equipped systems the patchset can cause data corruption,
>    data loss or unavailability of SCSI storage and boot failure.
> 
> Best regards,
> Krzysztof
> 
> ################################
> 
> The following changes since commit e7bd377c9219094136ecce5e2258f04edbed58a0:
> 
>    (upstream) media: uvcvideo: Fix pixel format change for Elgato Cam Link 4K (2021-06-30 08:28:01 +0200)
> 
> are available in the Git repository at:
> 
>    git+ssh://krzk@git.launchpad.net/~krzk/ubuntu/+source/linux tags/bug-1933518-scsi-smartpqi-microchip-update-v2
> 
> for you to fetch changes up to f4af293978afe2410e361cb3283b9a2296ae78b4:
> 
>    scsi: smartpqi: Remove unused functions (2021-07-05 14:03:52 +0200)
> 
> ----------------------------------------------------------------
> Update SmartPQI SCSI driver
> 
> * Microchip asks to update the SCSI SmartPQI driver to latest version
>    from upstream Linux kernel.
> * This contains mostly fixes and refactorings.
> * Updated driver allows to support properly latest SmartPQI controllers.
> 
> ----------------------------------------------------------------
> Bart Van Assche (1):
>        scsi: smartpqi: Remove unused functions
> 
> Don Brace (9):
>        scsi: smartpqi: Refactor aio submission code
>        scsi: smartpqi: Refactor scatterlist code
>        scsi: smartpqi: Add support for RAID5 and RAID6 writes
>        scsi: smartpqi: Add support for RAID1 writes
>        scsi: smartpqi: Add stream detection
>        scsi: smartpqi: Add host level stream detection enable
>        scsi: smartpqi: Update version to 2.1.8-045
>        scsi: smartpqi: Fix blocks_per_row static checker issue
>        scsi: smartpqi: Fix device pointer variable reference static checker issue
> 
> Kevin Barnett (18):
>        scsi: smartpqi: Add support for new product ids
>        scsi: smartpqi: Add support for BMIC sense feature cmd and feature bits
>        scsi: smartpqi: Add support for long firmware version
>        scsi: smartpqi: Align code with oob driver
>        scsi: smartpqi: Disable WRITE SAME for HBA NVMe disks
>        scsi: smartpqi: Remove timeouts from internal cmds
>        scsi: smartpqi: Add support for wwid
>        scsi: smartpqi: Update event handler
>        scsi: smartpqi: Update soft reset management for OFA
>        scsi: smartpqi: Synchronize device resets with mutex
>        scsi: smartpqi: Update suspend/resume and shutdown
>        scsi: smartpqi: Update RAID bypass handling
>        scsi: smartpqi: Update OFA management
>        scsi: smartpqi: Update device scan operations
>        scsi: smartpqi: Fix driver synchronization issues
>        scsi: smartpqi: Convert snprintf() to scnprintf()
>        scsi: smartpqi: Add additional logging for LUN resets
>        scsi: smartpqi: Correct system hangs when resuming from hibernation
> 
> Murthy Bhat (3):
>        scsi: smartpqi: Add phy ID support for the physical drives
>        scsi: smartpqi: Update SAS initiator_port_protocols and target_port_protocols
>        scsi: smartpqi: Update enclosure identifier in sysfs
> 
>   drivers/scsi/smartpqi/smartpqi.h               |  310 ++-
>   drivers/scsi/smartpqi/smartpqi_init.c          | 2992 ++++++++++++++----------
>   drivers/scsi/smartpqi/smartpqi_sas_transport.c |   39 +-
>   drivers/scsi/smartpqi/smartpqi_sis.c           |    9 +-
>   drivers/scsi/smartpqi/smartpqi_sis.h           |    1 +
>   5 files changed, 2044 insertions(+), 1307 deletions(-)
> 
The first patch in the set misses the BugLink ("scsi: smartpqi: Add support for 
new product ids") but we can add that.

-Stefan

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210706/4ca1c1db/attachment.sig>