NACK/Cmnt: [SRU][F:linux-bluefield][PATCH v4 1/4] UBUNTU: SAUCE: mlx-bootctl: Fix exclusion issues around arm_smccc_smc

[Shravan Ramani]

These patches need to be applied together.
I could create a single generic bug report mentioning all the updates
and/or bug fixes in this version of the driver, if that is preferable.
This was initially a single patch, but broke it up to avoid doing too many
things in one patch. Can I keep this split and just combine the bug reports,
or should I revert to having just one patch?
Will add the missing BugLink key and more info in the commit msg in v5.

Thanks,
Shravan

> -----Original Message-----
> From: Stefan Bader <stefan.bader at canonical.com>
> Sent: Tuesday, July 6, 2021 12:50 PM
> To: Shravan Ramani <shravankr at nvidia.com>; kernel-
> team at lists.ubuntu.com
> Subject: NACK/Cmnt: [SRU][F:linux-bluefield][PATCH v4 1/4] UBUNTU:
> SAUCE: mlx-bootctl: Fix exclusion issues around arm_smccc_smc
> 
> On 25.06.21 14:03, Shravan Kumar Ramani wrote:
> > https://bugs.launchpad.net/bugs/1933642
> 
> This misses the BugLink: key. But more importantly this should have a bit
> more explanation about the patch in the commit message. Also on the bug
> reports themselves. I think this initially was one and if a submission contains
> multiple patches they should be for the same bug report. The rule should be
> that anything that needs to be applied together should be one report and
> one submission. If things are independent they get their own bug report and
> should be submitted as their own thread.
> 
> -Stefan
> >
> > Signed-off-by: Shravan Kumar Ramani <shravankr at nvidia.com>
> > ---
> >   drivers/platform/mellanox/mlx-bootctl.c | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/platform/mellanox/mlx-bootctl.c
> > b/drivers/platform/mellanox/mlx-bootctl.c
> > index 6eff360551d9..67de265af5bb 100644
> > --- a/drivers/platform/mellanox/mlx-bootctl.c
> > +++ b/drivers/platform/mellanox/mlx-bootctl.c
> > @@ -298,8 +298,10 @@ static ssize_t oob_mac_show(struct device_driver
> *drv, char *buf)
> >   	struct arm_smccc_res res;
> >   	u8 *mac_byte_ptr;
> >
> > +	mutex_lock(&mfg_ops_lock);
> >   	arm_smccc_smc(MLNX_HANDLE_GET_MFG_INFO,
> MLNX_MFG_TYPE_OOB_MAC, 0, 0, 0,
> >   		      0, 0, 0, &res);
> > +	mutex_unlock(&mfg_ops_lock);
> >   	if (res.a0)
> >   		return -EPERM;
> >
> > @@ -364,7 +366,9 @@ static int get_opn_data(u64 *data, u8 word)
> >   	if (!type || !data)
> >   		return -EINVAL;
> >
> > +	mutex_lock(&mfg_ops_lock);
> >   	arm_smccc_smc(MLNX_HANDLE_GET_MFG_INFO, type, 0, 0, 0, 0, 0,
> 0,
> > &res);
> > +	mutex_unlock(&mfg_ops_lock);
> >   	if (res.a0)
> >   		return -EPERM;
> >
> > @@ -382,8 +386,10 @@ static int set_opn_data(u64 data, u8 word)
> >   	if (!type)
> >   		return -EINVAL;
> >
> > +	mutex_lock(&mfg_ops_lock);
> >   	arm_smccc_smc(MLNX_HANDLE_SET_MFG_INFO, type, sizeof(u64),
> data, 0, 0,
> >   		      0, 0, &res);
> > +	mutex_unlock(&mfg_ops_lock);
> >   	if (res.a0)
> >   		return -EPERM;
> >
> >
>