[F][SRU][PATCH 0/1] selftests/net: add missing tests to Makefile

Po-Hsu Lin po-hsu.lin at canonical.com
Tue Jul 6 04:55:59 UTC 2021


[Impact]
Found this issue while debugging devlink_port_split.py test issue in
bug 1928889.

There are some tests like icmp_redirect.sh, ip6_gre_headroom.sh and
etc are not in the Makefile of the net directory, thus they are not
tested at all.

[Fix]
* 919a23e9d6ccf8 selftests/net: add missing tests to Makefile

Backport needed for Focal as we only have these tests unadded:
$ for file in $(ls *.sh); do grep -q $file Makefile || echo $file; done
fib_nexthop_multiprefix.sh
fib_nexthops.sh
icmp_redirect.sh
ip6_gre_headroom.sh
route_localnet.sh

Note that this must be applied after patch for lp:1934293
https://lists.ubuntu.com/archives/kernel-team/2021-July/121948.html

(I tried to create the patch with --base, but it seems the git is too
old on kathleen.)

[Test]
Run the "net" test suite in the kselftest directory from a patched
source tree. These tests will be executed.

[Where problems could occur]
This change will bring in more tests for our SRU, we might see new
failures because of these test in the future.

Hangbin Liu (1):
  selftests/net: add missing tests to Makefile

 tools/testing/selftests/net/Makefile | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.7.4




More information about the kernel-team mailing list