ACK/cmt: Re: [F-oem-5.10/F-oem-5.13][H/I/Unstable][SRU][PATCH 0/1] selftests: net: devlink_port_split.py: skip the test if no devlink device

Paolo Pisati paolo.pisati at canonical.com
Fri Jul 2 14:16:48 UTC 2021


On Thu, Jul 01, 2021 at 04:04:41PM +0800, Po-Hsu Lin wrote:
> [Impact]
> If there is no devlink device available, the devlink_port_split.py in
> kselftest/net will fail with:
>  # selftests: net: devlink_port_split.py
>  # Traceback (most recent call last):
>  # File "/tmp/autopkgtest.ojlWKQ/build.XZw/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 277, in <module>
>  # main()
>  # File "/tmp/autopkgtest.ojlWKQ/build.XZw/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 242, in main
>  # dev = list(devs.keys())[0]
>  # IndexError: list index out of range
>  not ok 43 selftests: net: devlink_port_split.py # exit=1

I upstreamed a similar fix the other day:

https://lore.kernel.org/lkml/162492240312.3183.18165138324418989489.git-patchwork-notify@kernel.org/T/

but yours look nicer, so:

Acked-by: Paolo Pisati <paolo.pisati at canonical.com>
-- 
bye,
p.



More information about the kernel-team mailing list