ACK/Cmnt: [F-oem-5.6/F-oem-5.10/F-oem-5.13][F/G/H][SRU][PATCH 1/1] selftests: icmp_redirect: support expected failures
po-hsu.lin at canonical.com
Thu Jul 1 07:15:34 UTC 2021
On Thu, Jul 1, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski at canonical.com> wrote:
> On 01/07/2021 08:26, Po-Hsu Lin wrote:
> > From: Andrea Righi <andrea.righi at canonical.com>
> > BugLink: https://bugs.launchpad.net/bugs/1880645
> > According to a comment in commit 99513cfa16c6 ("selftest: Fixes for
> > icmp_redirect test") the test "IPv6: mtu exception plus redirect" is
> > expected to fail, because of a bug in the IPv6 logic that hasn't been
> > fixed yet apparently.
> > We should probably consider this failure as an "expected failure",
> > therefore change the script to return XFAIL for that particular test and
> > also report the total amount of expected failures at the end of the run.
> > Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
> > Signed-off-by: David S. Miller <davem at davemloft.net>
> > (cherry picked from commit 0a36a75c6818800c67057458376e99b5f77c2a1f)
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> > ---
> > tools/testing/selftests/net/icmp_redirect.sh | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> Shouldn't it go to all series and flavors (e.g. v5.8)?
yes it should go to all flavours (variants), but since this test only
exist since Focal, I think it's not needed for older series. Unless we
are going to add this test there.
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Best regards,
More information about the kernel-team