[PATCH][SRU][F-hwe-5.11 25/30] scsi: smartpqi: Update enclosure identifier in sysfs

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Thu Jul 1 06:51:36 UTC 2021

From: Murthy Bhat <Murthy.Bhat at microchip.com>

BugLink: https://bugs.launchpad.net/bugs/1933518

Update enclosure identifier field corresponding to physical devices in

During device add the SCSI devtype is filled in during slave_configure().
However, when pqi_scsi_update_device() runs (REGNEWD) the firmware returns
zero for the SCSI devtype field, and valid devtype is overwritten by
zero. Due to this, lsscsi output shows wrong values.

Link: https://lore.kernel.org/r/161549385708.25025.17234953506918043750.stgit@brunhilda
Reviewed-by: Scott Benesh <scott.benesh at microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen at microchip.com>
Reviewed-by: Scott Teel <scott.teel at microchip.com>
Reviewed-by: Kevin Barnett <kevin.barnett at microchip.com>
Signed-off-by: Murthy Bhat <Murthy.Bhat at microchip.com>
Signed-off-by: Don Brace <don.brace at microchip.com>
Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
(cherry picked from commit d0cba99fd7a3781a78f751cfd4f4e3ff4d0b1ea3)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
 drivers/scsi/smartpqi/smartpqi_init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 2f29b2c0f24a..40488927f1fd 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -1840,7 +1840,6 @@ static void pqi_dev_info(struct pqi_ctrl_info *ctrl_info,
 static void pqi_scsi_update_device(struct pqi_scsi_dev *existing_device,
 	struct pqi_scsi_dev *new_device)
-	existing_device->devtype = new_device->devtype;
 	existing_device->device_type = new_device->device_type;
 	existing_device->bus = new_device->bus;
 	if (new_device->target_lun_valid) {

More information about the kernel-team mailing list