[F-oem-5.6/F-oem-5.10/F-oem-5.13][F/G/H][SRU][PATCH 0/1] selftests: icmp_redirect: support expected failures

Po-Hsu Lin po-hsu.lin at canonical.com
Thu Jul 1 06:26:12 UTC 2021


[Impact]
The IPv6: mtu exception plus redirect test in icmp_redirect.sh test
from kselftest/net is expected to fail due to a known bug in the
IPv6 logic.

When trying to run this test you will see this sub test fail with:
TEST: IPv6: mtu exception plus redirect [FAIL]

and thus causing non-zero return value for this script.

[Fix]
* 0a36a75c681880 selftests: icmp_redirect: support expected failures

This fix can be cherry-picked into all affected series. And it has
already landed on Unstable, test passed with Impish 5.13.

Although we have this script in Focal kernel as well, but it's not
being executed at all. This is another issue that will be dealt in
a different bug report.

[Test]
Run the patched icmp_redirect.sh test manually in
tools/testing/selftests/net, this sub-test will be marked as XFAIL
and the return value of this script will be 0:
$ sudo ./icmp_redirect.sh
....
#####################################################################
Routing with nexthop objects and VRF
#####################################################################
TEST: IPv6: mtu exception plus redirect [XFAIL]

Tests passed: 36
Tests failed: 0
Tests xfailed: 4
$ echo $?
0

[Where problems could occur]
Change limited to testing tool, not affecting actual kernel
functionality. The only possible issue that I can think of is that
as this script is no longer complaining about this failure, people
might forgot there is such an issue exist in ipv6.

Andrea Righi (1):
  selftests: icmp_redirect: support expected failures

 tools/testing/selftests/net/icmp_redirect.sh | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.7.4




More information about the kernel-team mailing list