[SRU v2] [G] [PATCH 0/6] Prevent thermal shutdown during boot process

Kai-Heng Feng kai.heng.feng at canonical.com
Wed Jan 27 12:00:08 UTC 2021


On Wed, Jan 27, 2021 at 7:02 PM Paolo Pisati <paolo.pisati at canonical.com> wrote:
>
> On Wed, Jan 27, 2021 at 11:05:11AM +0800, Kai-Heng Feng wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1906168
> >
> > [Impact]
> > Surprising thermal shutdown at boot on Intel based mobile workstations.
> >
> > [Fix]
> > Since these thermal devcies are not in ACPI ThermalZone, OS shouldn't
> > shutdown the system.
> >
> > These critial temperatures are for usespace to handle, so let kernel
> > know it shouldn't handle it.
> >
> > For Groovy, a patch that removes .notify callback is dropped.
> >
> > [Test]
> > Use reboot stress as a reproducer. 5% chance to see a surprising
> > shutdown at boot.
> >
> > With the fix applied, the thermal shutdown is no longer reproducible.
> >
> > [Where problems could occur]
> > For ACPI based platforms, we still have "acpitz" to protect systems from
> > overheating. If these acpitz sensors don't work, then the system could
> > face real overheating issue.
> >
> > Daniel Lezcano (4):
> >   thermal/core: Emit a warning if the thermal zone is updated without
> >     ops
> >   thermal/core: Add critical and hot ops
> >   thermal/drivers/acpi: Use hot and critical ops
> >   thermal/drivers/rcar: Remove notification usage
> >
> > Kai-Heng Feng (2):
> >   thermal: int340x: Fix unexpected shutdown at critical temperature
> >   thermal: intel: pch: Fix unexpected shutdown at critical temperature
>
> Hi Kai-Heng,
>
> looks like this v2 patchset is identical to v1 but dropped:
>
> commit 2079c0fe7fd0b46bc00e341205aa325bae7406b7
> Author: Daniel Lezcano <daniel.lezcano at linaro.org>
> Date:   Thu Jan 21 16:49:00 2021 +0800
>
>     thermal/core: Remove notify ops
>
> and in Hirsute (5.10+) we have the v1 applied - shall we keep v1 applied? Or
> shall we drop the above patch?

Please keep v1 applied. Since Hirsute isn't a stable kernel yet, I
hope it can be as close as upstream version.

Kai-Heng

> --
> bye,
> p.



More information about the kernel-team mailing list