APPLIED[F/G]: [F/G/H/Unstable][F/oem-5.6][SRU][PATCH 0/1] selftests: fix poll error in udpgro.sh

[Kelsey Skunberg]

These were applied to F/G through an upstream patch. Thank you! 

-Kelsey

On 2020-12-17 17:39:28 , Po-Hsu Lin wrote:
> [Impact]
> Sub test cases in kselftest/net/udpgro.sh is failing with:
>     ./udpgso_bench_rx: poll: 0x0 expected 0x1
> 
> Complete test output of a sub test case:
>  multiple GRO socks
> BTF debug data section '.BTF' rejected: Invalid argument (22)!
>  - Length: 568
> Verifier analysis:
> 
> magic: 0xeb9f
> version: 1
> flags: 0x0
> hdr_len: 24
> type_off: 0
> type_len: 256
> str_off: 256
> str_len: 288
> btf_total_size: 568
> [1] PTR (anon) type_id=2
> [2] STRUCT xdp_md size=20 vlen=5
>  data type_id=3 bits_offset=0
>  data_end type_id=3 bits_offset=32
>  data_meta type_id=3 bits_offset=64
>  ingress_ifindex type_id=3 bits_offset=96
>  rx_queue_index type_id=3 bits_offset=128
> [3] TYPEDEF __u32 type_id=4
> [4] INT unsigned int size=4 bits_offset=0 nr_bits=32 encoding=(none)
> [5] FUNC_PROTO (anon) return=6 args=(1 ctx)
> [6] INT int size=4 bits_offset=0 nr_bits=32 encoding=SIGNED
> [7] FUNC xdp_dummy_prog type_id=5
> [8] INT char size=1 bits_offset=0 nr_bits=8 encoding=SIGNED
> [9] ARRAY (anon) type_id=8 index_type_id=10 nr_elems=4
> [10] INT __ARRAY_SIZE_TYPE__ size=4 bits_offset=0 nr_bits=32 encoding=(none)
> [11] VAR _license type_id=9 linkage=1
> [12] DATASEC license size=0 vlen=1 size == 0
> 
> ./udpgso_bench_rx: poll: 0x0 expected 0x1
> 
> ./udpgso_bench_rx: poll: 0x0 expected 0x1
> 
> failed
> 
> It's a bit hard to spot this as the udpgro.sh will return 0 even with
> these failures present (bug 1908499)
> 
> [Fix]
> * 38bf8cd821be29 ("selftests: fix poll error in udpgro.sh")
> 
> We have this test case since Focal.
> This patch can be cherry-picked into all the affected releases.
> 
> [Test Case]
> Run the kselftest/net/udpgro.sh as root.
> 
> It will no longer complaining about this error message anymore:
>  ./udpgso_bench_rx: poll: 0x0 expected 0x1
> 
>  multiple GRO socks
> BTF debug data section '.BTF' rejected: Invalid argument (22)!
>  - Length: 568
> Verifier analysis:
> 
> magic: 0xeb9f
> version: 1
> flags: 0x0
> hdr_len: 24
> type_off: 0
> type_len: 256
> str_off: 256
> str_len: 288
> btf_total_size: 568
> [1] PTR (anon) type_id=2
> [2] STRUCT xdp_md size=20 vlen=5
>  data type_id=3 bits_offset=0
>  data_end type_id=3 bits_offset=32
>  data_meta type_id=3 bits_offset=64
>  ingress_ifindex type_id=3 bits_offset=96
>  rx_queue_index type_id=3 bits_offset=128
> [3] TYPEDEF __u32 type_id=4
> [4] INT unsigned int size=4 bits_offset=0 nr_bits=32 encoding=(none)
> [5] FUNC_PROTO (anon) return=6 args=(1 ctx)
> [6] INT int size=4 bits_offset=0 nr_bits=32 encoding=SIGNED
> [7] FUNC xdp_dummy_prog type_id=5
> [8] INT char size=1 bits_offset=0 nr_bits=8 encoding=SIGNED
> [9] ARRAY (anon) type_id=8 index_type_id=10 nr_elems=4
> [10] INT __ARRAY_SIZE_TYPE__ size=4 bits_offset=0 nr_bits=32 encoding=(none)
> [11] VAR _license type_id=9 linkage=1
> [12] DATASEC license size=0 vlen=1 size == 0
> 
> ok
> 
> [Where problems could occur]
> The fix is limited to testing tools, no actual affect to the kernel.
> The possible issue is that this patch is incorrect and it will make
> us ignore the real issue in the kernel.
> 
> Paolo Abeni (1):
>   selftests: fix poll error in udpgro.sh
> 
>  tools/testing/selftests/net/udpgso_bench_rx.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team