NAK: [SRU][F:linux-bluefield][PULL] Focal update: kTLS fixes

Tim Gardner tim.gardner at canonical.com
Wed Feb 24 13:14:54 UTC 2021



On 2/22/21 9:00 AM, Daniel Jurgens wrote:
> This pull request (4 commits) contains fixes for kTLS offloads.
> 
> TLS fixes:
> https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1916508
> 
> These commits were clean cherry-picks from upstream.
> 
> ~danielj-mellanox/ubuntu/+source/linux-bluefield tls_fixes
> 
> ----------------------------------------------------------------
> 
> The following changes since commit f5bad1cceee57cba53c477d9b427a17043ea8cd0:
> 
>    UBUNTU: SAUCE: Fix intermittent OOB link up issue (2021-02-03 18:10:47 +0800)
> 
> are available in the git repository at:
> 
>    git+ssh://danielj-mellanox@git.launchpad.net/~danielj-mellanox/ubuntu/+source/linux-bluefield tls_fixes
> 
> for you to fetch changes up to 05a375cb0fd55ee4f96e38d6788c86653e49ea77:
> 
>    net/tls: Protect from calling tls_dev_del for TLS RX twice (2021-02-19 22:42:51 +0200)
> 
> ----------------------------------------------------------------
> Boris Pismenny (1):
>        net/tls: Add asynchronous resync
> 
> Colin Ian King (1):
>        net/tls: fix sign extension issue when left shifting u16 value
> 
> Maxim Mikityanskiy (1):
>        net/tls: Protect from calling tls_dev_del for TLS RX twice
> 
> Tariq Toukan (1):
>        net/tls: Fix wrong record sn in async mode of device resync
> 
>   include/net/tls.h    | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   net/tls/tls_device.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   2 files changed, 129 insertions(+), 2 deletions(-)
> 

Your patches are missing SOB attribution and LP number. When 
cherry-picking use the '-s -x' options.

You can use maintscripts/maint-modify-patch from 
git://git.launchpad.net/~canonical-kernel/+git/kteam-tools to insert a 
Launchpad buglink into your patch. It will be of the form:

https://bugs.launchpad.net/bugs/1916508

I'm not sure what the limit is for other developers on the list, but my 
rule of thumb is that if there are 6 or fewer patches then I use 'git 
send-email --compose' to attach the patches to a thread. Its quicker to 
review then having to go clone (or update) a repository and fetch your 
changes.

rtg
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list