ACK: [F][SRU][PATCH 1/1] selftests/eeh: Skip ahci adapters

Kleber Souza kleber.souza at canonical.com
Wed Feb 24 09:45:11 UTC 2021


On 24.02.21 08:14, Po-Hsu Lin wrote:
> From: Michael Ellerman <mpe at ellerman.id.au>
> 
> BugLink: https://bugs.launchpad.net/bugs/1916468
> 
> The ahci driver doesn't support error recovery, and if your root
> filesystem is attached to it the eeh-basic.sh test will likely kill
> your machine.
> 
> So skip any device we see using the ahci driver.
> 
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> Link: https://lore.kernel.org/r/20200326061144.2006522-1-mpe@ellerman.id.au
> (cherry picked from commit bbe9064f30f06e7791d04f9f61a842226a6a44fe)
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

> ---
>   tools/testing/selftests/powerpc/eeh/eeh-basic.sh | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> index cf001a2..0d783e1 100755
> --- a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> +++ b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> @@ -43,6 +43,11 @@ for dev in `ls -1 /sys/bus/pci/devices/ | grep '\.0$'` ; do
>   		continue;
>   	fi
>   
> +	if [ "ahci" = "$(basename $(realpath /sys/bus/pci/devices/$dev/driver))" ] ; then
> +		echo "$dev, Skipped: ahci doesn't support recovery"
> +		continue
> +	fi
> +
>   	# Don't inject errosr into an already-frozen PE. This happens with
>   	# PEs that contain multiple PCI devices (e.g. multi-function cards)
>   	# and injecting new errors during the recovery process will probably
> 




More information about the kernel-team mailing list