NAK: [PATCH 0/2][SRU][linux-firmware][B] add firmware for Realtek RTL8153 Based USB Ethernet Adapters

[You-Sheng Yang]

typo in BugLink url. Updated in v2.

On 2/23/21 3:22 PM, Juerg Haefliger wrote:
>> BugLink: https://bugs.launchpad.net/bug/1890641
> 
> Bug does not exist.
> 
> ...Juerg
> 
> 
>> [Impact]
>>
>> Missing firmware for Realtek RTL8153 Based USB Ethernet Adapters, which
>> is supported by linux-generic-hwe-18.04 kernel (currently v5.4).
>>
>> [Fix]
>>
>> Two upstream commit necessary:
>> * commit b27d12383e7a ("rtl_nic: add firmware files for RTL8153")
>> * commit 6f89735800fe ("rtl_nic: update firmware for RTL8153A")
>>
>> [Test Case]
>>
>> Without firmware, drive probe would fail with:
>>
>>   $ dmesg | grep firmware | grep rtl8153
>>   r8152 2-4.1:1.0: firmware: failed to load rtl_nic/rtl8153a-2.fw (-2)
>>   r8152 2-4.1:1.0: Direct firmware load for rtl_nic/rtl8153a-2.fw failed with error -2
>>   r8152 2-4.1:1.0: unable to load firmware patch rtl_nic/rtl8153a-2.fw (-2)
>>
>> With firmware, it should succeed:
>>
>>   $ dmesg | grep rtl8152
>>   r8152 2-1:1.0: load rtl8153a-3 v2 02/07/20 successfully
>>   r8152 2-1:1.0 eth0: v1.11.11
>>   r8152 2-1:1.0 enp0s20f0u1: renamed from eth0
>>
>> [Where problems could occur]
>>
>> While this introduces new firmware blobs and enabled devices supported
>> by new kernels, it should have little effect on existing systems, but
>> with new devices up and running, it may still affect power consumptions,
>> ability to enter deep suspend, etc.
>>
>> [Other Info]
>>
>> RTL8153 firmware has been available on Eoan and newer, so only Bionic is
>> nominated.
>>
>> Hayes Wang (2):
>>   rtl_nic: add firmware files for RTL8153
>>   rtl_nic: update firmware for RTL8153A
>>
>>  WHENCE                |  11 +++++++++++
>>  rtl_nic/rtl8153a-2.fw | Bin 0 -> 1768 bytes
>>  rtl_nic/rtl8153a-3.fw | Bin 0 -> 1440 bytes
>>  rtl_nic/rtl8153a-4.fw | Bin 0 -> 712 bytes
>>  rtl_nic/rtl8153b-2.fw | Bin 0 -> 1088 bytes
>>  5 files changed, 11 insertions(+)
>>  create mode 100644 rtl_nic/rtl8153a-2.fw
>>  create mode 100644 rtl_nic/rtl8153a-3.fw
>>  create mode 100644 rtl_nic/rtl8153a-4.fw
>>  create mode 100644 rtl_nic/rtl8153b-2.fw
>>
>