NACK/Cmnt[F/G]: [SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Fix broken efifb on graphics device without driver

Stefan Bader stefan.bader at canonical.com
Thu Feb 18 09:44:44 UTC 2021


On 03.02.21 17:40, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1914411
> 
> [Impact]
> EFIFB stops working after graphics device is runtime suspended in
> D3cold.
> 
> [Fix]
> Prevent the graphics device from being runtime suspended.
> 
> [Test]
> With the patch applied, using efifb on graphics device without driver
> always work, because the device stays at D0 all the time.
> 
> [Where problems could occur]
> Potentially this can affect power consumption, if user expects to put
> graphics device to D3cold, and is fine to get a broken efifb.
> 
> Kai-Heng Feng (1):
>   UBUNTU: SAUCE: efifb: Ensure graphics device for efifb stays at PCI D0
> 
>  drivers/video/fbdev/efifb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Sorry about this late rejection but after hoping to see this at least on
linux-next which did not happen, I checked the provided link and that also seems
to have dead-ended after a review.
I cannot decide for F:linux-oem-5.10 or unstable, but for stable release updates
this does not look acceptable.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210218/9b9ee6af/attachment.sig>


More information about the kernel-team mailing list