NACK/Cmnt: [PATCH] [PATCH Groovy] Azure: Enable CONFIG_ASHMEM=m, CONFIG_ANDROID_BINDER_IPC=m

[Stefan Bader]

On 16.02.21 18:48, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1914568
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---

Hm, I think I will NACK this and its Focal companion as well. Not for content
but formal reasons. The bug report should match series tasks with what is
submitted. Right now it only has hirsute and focal tasks. Also there should be a
SRU template (best prepended in the description because that is what is most
visisble). The status of the task should be at least confirmed or triaged and
personally I would like to see importance set as well. 'medium' in most cases.

When sending things to the mailing list it should be using a cover email and the
series patches as follow-ups (would have the advantage that for patches which
are shared between series they have to be sent only once and looked at only
once). Also in this case both patches will be very similar. So when looking at
one, then one can quickly do the other, too. And when applying patches it helps
to get everything applied in lockstep.

-Stefan

>  debian.azure/config/annotations          | 9 +++++++++
>  debian.azure/config/config.common.ubuntu | 7 ++++++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.azure/config/annotations b/debian.azure/config/annotations
> index 9ce018acaac3..851484049303 100644
> --- a/debian.azure/config/annotations
> +++ b/debian.azure/config/annotations
> @@ -4,6 +4,15 @@
>  
>  include "../../debian.master/config/annotations"
>  
> +CONFIG_ANDROID                                     policy<{'amd64': 'y'}>
> +CONFIG_ANDROID                                     mark<ENFORCED> note<LP:#1914568>
> +
> +CONFIG_ASHMEM                                      policy<{'amd64': 'm'}>
> +CONFIG_ASHMEM                                      mark<ENFORCED> note<LP:#1914568>
> +
> +CONFIG_ANDROID_BINDER_IPC                          policy<{'amd64': 'm'}>
> +CONFIG_ANDROID_BINDER_IPC                          mark<ENFORCED> note<LP:#1914568>
> +
>  CONFIG_MLX5_CORE                                   policy<{'amd64': 'm'}>
>  CONFIG_MLX5_CORE                                   mark<ENFORCED> note<LP:#1837397>
>  
> diff --git a/debian.azure/config/config.common.ubuntu b/debian.azure/config/config.common.ubuntu
> index 8157e9375eda..2fa70083b75e 100644
> --- a/debian.azure/config/config.common.ubuntu
> +++ b/debian.azure/config/config.common.ubuntu
> @@ -145,7 +145,11 @@ CONFIG_AMD_NUMA=y
>  # CONFIG_AMD_PHY is not set
>  CONFIG_AMIGA_PARTITION=y
>  # CONFIG_AMILO_RFKILL is not set
> -# CONFIG_ANDROID is not set
> +CONFIG_ANDROID=y
> +# CONFIG_ANDROID_BINDERFS is not set
> +CONFIG_ANDROID_BINDER_DEVICES="binder,hwbinder,vndbinder"
> +CONFIG_ANDROID_BINDER_IPC=m
> +# CONFIG_ANDROID_BINDER_IPC_SELFTEST is not set
>  CONFIG_APDS9802ALS=m
>  # CONFIG_APPLE_GMUX is not set
>  CONFIG_APPLE_MFI_FASTCHARGE=m
> @@ -249,6 +253,7 @@ CONFIG_ARCNET_COM90xx=m
>  CONFIG_ARCNET_COM90xxIO=m
>  CONFIG_ARCNET_RAW=m
>  CONFIG_ARCNET_RIM_I=m
> +CONFIG_ASHMEM=m
>  CONFIG_ASN1=y
>  CONFIG_ASSOCIATIVE_ARRAY=y
>  # CONFIG_ASUS_LAPTOP is not set
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210217/1e0ba8bc/attachment-0001.sig>